From owner-svn-src-all@freebsd.org Tue Dec 3 21:12:23 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8C9B61BDBE8 for ; Tue, 3 Dec 2019 21:12:23 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound3d.ore.mailhop.org (outbound3d.ore.mailhop.org [54.186.57.195]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47SF6v13q1z3xsk for ; Tue, 3 Dec 2019 21:12:22 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1575407542; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=YbCpcVi/LsiCKXc6oiJk0DmRThnKlEmO8XcYNB6KGwTPSAivek1KCD9y66uUfMLBw55w056V0Iy66 i99Pgiou9CKVsC5Icl4hmdYzEVyZbJtSrh9gttG/TEiP/eqbGyVlr18FvquBM84ERM+4BZJtfwMVEg FoRomYiExIwNj9kCfE0W3kvC9hmsmKQlr2fNFYabkH65WMVFQ0TT0joYPw0BwrkT9CxIraetUUIIE3 b7pAF9MpzlizaFeam1LG8WvSDrR89K6XV94LffWu6doeVD48UmpCSOOPBbH9Ynhe4g/7Iuef+pi84X +l6G0dBsCHXuQlPs2d6aK+LunTl0rRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=C46ifX+KeabPdkLyODqhMlrlpFI8mRcLhe3zDdx4Yd0=; b=pz5q25zyatWllYxFAWZeJFlgU+Gtd14pEX6Kfo0y9kmSFnWnEurMOMCJyPaJ1LkRvrOJYROUYF693 MR+ZpP08RCJr9VoDgQn6COHOyCndaWSXnavVkSB68sgcobBhTroCKnnI4CTUT3iik0R09SWDRNIf+p gCNQDH+5fetcKKZiq91EIjyCHP8k3LlxSr6+X0+3ecM45HYxhHVMpiOYls/MeB9DGZG9g9wm3+LLww nS1CyUKHIqtsYffDWqa62ZKr9WmvtVnntuNeHdFyOcXit3eI1p4PIgxc7UyQQCnJU6KmQdWvx3w9Rk fgBU5XXvu7Od1i5eBWifq3xih8fBO4w== ARC-Authentication-Results: i=1; outbound3.ore.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=C46ifX+KeabPdkLyODqhMlrlpFI8mRcLhe3zDdx4Yd0=; b=kH2jwGsPrK5vK2vSuEXujhT30sCmm01QuE+xFltdMvSlTiLHibVvZJINR+81B7wErR4QtQxgknLfS sXCCFVErr9czTxJSWUEekGBmg85N7rHVXbBHYYjWxZnoxDCWAFCIgVbx0ZynQykjZXspGKcV7yzN3Q 3LuLht6X/Mnzej1t63yJ7RQG8uLXmOYBf8DMU5q7XUzC0i0uPx8Mbr3/ek5b+9YvAG2Nx3m8SgR+oq qE/qO0yC0/BQluFpycInA3iYl1gj6Ze9PH1KwtgNIz6ZYeYyXLV4XgO1px3fymEyjb9WP/w5z+v1dK QPZMj9nslM7m5yrhxu1iKpB+Dv8DiYg== X-MHO-RoutePath: aGlwcGll X-MHO-User: 971b7fe9-1611-11ea-b80c-052b4a66b6b2 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound3.ore.mailhop.org (Halon) with ESMTPSA id 971b7fe9-1611-11ea-b80c-052b4a66b6b2; Tue, 03 Dec 2019 21:12:20 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id xB3LCJXQ000929; Tue, 3 Dec 2019 14:12:19 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: Subject: Re: svn commit: r355137 - head/sys/vm From: Ian Lepore To: Ryan Libby , Gleb Smirnoff Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 03 Dec 2019 14:12:19 -0700 In-Reply-To: References: <201911271949.xARJnuFl084178@repo.freebsd.org> <20191203204313.GB2706@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 FreeBSD GNOME Team Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 47SF6v13q1z3xsk X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.91 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.97)[-0.968,0]; NEURAL_HAM_LONG(-0.94)[-0.943,0]; ASN(0.00)[asn:16509, ipnet:54.186.0.0/15, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2019 21:12:23 -0000 On Tue, 2019-12-03 at 12:59 -0800, Ryan Libby wrote: > > + * XXX UMA_ZONE_OFFPAGE. All over freebsd we have cryptic XXX comments that have no meaning to anyone except whoever wrote them (and, I suspect, no meaning to those people either after a couple months have elapsed). To the degree that XXX represents "possible trouble here" and/or "more work to do here", I would argue that any placement of a new XXX requires at least a sentence (and probably more like a paragraph) to describe why it's there. -- Ian