From owner-cvs-src-old@FreeBSD.ORG  Sun Oct  3 13:52:34 2010
Return-Path: <owner-cvs-src-old@FreeBSD.ORG>
Delivered-To: cvs-src-old@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A99DA1065697
	for <cvs-src-old@freebsd.org>; Sun,  3 Oct 2010 13:52:34 +0000 (UTC)
	(envelope-from kib@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 7F2838FC28
	for <cvs-src-old@freebsd.org>; Sun,  3 Oct 2010 13:52:34 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o93DqYF2051941
	for <cvs-src-old@freebsd.org>; Sun, 3 Oct 2010 13:52:34 GMT
	(envelope-from kib@repoman.freebsd.org)
Received: (from svn2cvs@localhost)
	by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o93DqYAm051940
	for cvs-src-old@freebsd.org; Sun, 3 Oct 2010 13:52:34 GMT
	(envelope-from kib@repoman.freebsd.org)
Message-Id: <201010031352.o93DqYAm051940@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to
	kib@repoman.freebsd.org using -f
From: Konstantin Belousov <kib@FreeBSD.org>
Date: Sun, 3 Oct 2010 13:52:17 +0000 (UTC)
To: cvs-src-old@freebsd.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/amd64/amd64 machdep.c
X-BeenThere: cvs-src-old@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the src tree
	<cvs-src-old.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src-old>
List-Post: <mailto:cvs-src-old@freebsd.org>
List-Help: <mailto:cvs-src-old-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src-old>,
	<mailto:cvs-src-old-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Oct 2010 13:52:34 -0000

kib         2010-10-03 13:52:17 UTC

  FreeBSD src repository

  Modified files:
    sys/amd64/amd64      machdep.c 
  Log:
  SVN rev 213382 on 2010-10-03 13:52:17Z by kib
  
  The makectx() function, used by kdb_trap() to reconstruct pcb from
  trap frame when trap initiated kdb entry, incorrectly calculated the
  value of %rsp for trapped thread.
  
  According to Intel(R) 64 and IA-32 Architectures Software Developer's Manual
  Volume 3A: System Programming Guide, Part 1, rev. 035, 6.14.2 64-Bit Mode
  Stack Frame, "64-bit mode ... pushes SS:RSP unconditionally, rather than
  only on a CPL change."
  Even assuming the conditional push of the %ss:%rsp, the calculation
  was still wrong because sizeof(tf_ss) + sizeof(tf_rsp) == 16 on amd64.
  
  Always use the tf_rsp from trap frame. The change supposedly fixes
  stepping when using kgdb backend for kdb.
  
  Submitted by:   Zhouyi Zhou <zhouzhouyi gmail com>
  PR:     amd64/151167
  Reviewed by:    avg
  MFC after:      1 week
  
  Revision  Changes    Path
  1.725     +1 -1      src/sys/amd64/amd64/machdep.c