From owner-cvs-all@FreeBSD.ORG Tue Oct 11 04:10:01 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D06416A41F; Tue, 11 Oct 2005 04:10:01 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: from mail3out.barnet.com.au (mail3out.barnet.com.au [202.83.176.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4633343D45; Tue, 11 Oct 2005 04:10:00 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: by mail3out.barnet.com.au (Postfix, from userid 27) id D68D3877C5E; Tue, 11 Oct 2005 14:09:58 +1000 (EST) X-Viruscan-Id: <434B3B1600000A745B683C@BarNet> Received: from mail3-auth.barnet.com.au (mail3.barnet.com.au [202.83.176.16]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.barnet.com.au", Issuer "BarNet Root Certificate Authority" (verified OK)) by mail3.barnet.com.au (Postfix) with ESMTP id A3050877C51; Tue, 11 Oct 2005 14:09:58 +1000 (EST) Received: from k7.mavetju (edwin-3.int.barnet.com.au [10.10.12.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "edwin.adsl.barnet.com.au", Issuer "BarNet Root Certificate Authority" (not verified)) by mail3-auth.barnet.com.au (Postfix) with ESMTP id 2FBD8877C32; Tue, 11 Oct 2005 14:09:58 +1000 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id D715A614D; Tue, 11 Oct 2005 14:09:56 +1000 (EST) Date: Tue, 11 Oct 2005 14:09:56 +1000 From: Edwin Groothuis To: Adam Weinberger Message-ID: <20051011040956.GC1239@k7.mavetju> References: <200510101133.j9ABXWg4000289@repoman.freebsd.org> <20051010125906.GA3640@FreeBSD.org> <20051010234044.GB1239@k7.mavetju> <434B2841.3@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <434B2841.3@FreeBSD.org> User-Agent: Mutt/1.5.9i Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev , Jean-Marc Zucconi , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/doom Makefile ports/games/doom/files patch-ag patch-sndserv__soundsrv.c patch-sndserv__wadread.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2005 04:10:01 -0000 On Mon, Oct 10, 2005 at 10:49:37PM -0400, Adam Weinberger wrote: > But OTOH, using a REINPLACE saves you from having to regenerate patches > for every single update. It might make initial patching a bit trickier, > but it can prevent unexpected problem from popping up in the future. > > In my eyes, saying that people shouldn't use pre-patch instead of patch > files to prevent difficult sequential patching is akin to saying that > people shouldn't own cars because they might slam their fingers in the > door ::P Patches for ports which replace anything but FreeBSD specific things (and then paths are the only things I can think about) should be fed upstream and removed in the next upgrade. Just doing blind drive-by replacements for things which went wrong in the past is not quality. And with this I stop argueing about it. I gave good reasons in the first reply. Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/