From owner-freebsd-usb@freebsd.org  Thu Jan 19 17:39:06 2017
Return-Path: <owner-freebsd-usb@freebsd.org>
Delivered-To: freebsd-usb@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52056CB59F3
 for <freebsd-usb@mailman.ysv.freebsd.org>;
 Thu, 19 Jan 2017 17:39:06 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 41A7C1B86
 for <freebsd-usb@FreeBSD.org>; Thu, 19 Jan 2017 17:39:06 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v0JHd5dW074652
 for <freebsd-usb@FreeBSD.org>; Thu, 19 Jan 2017 17:39:06 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-usb@FreeBSD.org
Subject: [Bug 216261] [patch] Resume failing without xhci controller reset
Date: Thu, 19 Jan 2017 17:39:06 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: usb
X-Bugzilla-Version: CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: yanko.yankulov@gmail.com
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-usb@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status keywords bug_severity priority component assigned_to
 reporter cc attachments.created
Message-ID: <bug-216261-17@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-usb@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: FreeBSD support for USB <freebsd-usb.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-usb/>
List-Post: <mailto:freebsd-usb@freebsd.org>
List-Help: <mailto:freebsd-usb-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-usb>,
 <mailto:freebsd-usb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jan 2017 17:39:06 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D216261

            Bug ID: 216261
           Summary: [patch] Resume failing without xhci controller reset
           Product: Base System
           Version: CURRENT
          Hardware: amd64
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Some People
          Priority: ---
         Component: usb
          Assignee: freebsd-usb@FreeBSD.org
          Reporter: yanko.yankulov@gmail.com
                CC: freebsd-amd64@FreeBSD.org
          Keywords: patch
                CC: freebsd-amd64@FreeBSD.org

Created attachment 179073
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179073&action=
=3Dedit
propoesed patch

On my new Skylake based laptop Suspend/Resume was failing (no resume_beep at
all). I was able to resolve the issue by adding controller reset of the xhci
controller after the xhci_halt_controller calls.

The problem is clearly BIOS bug as the Suspend/Resume is failing without
loading the xhci driver. The same is happening with latest Linux when the x=
hci
driver is not loaded.

Adding the reset code solves the issue. The Linux driver seems to do the sa=
me
on driver unload, so I am not expecting a regression by the change.

A simple patch to implement this is attached.

--=20
You are receiving this mail because:
You are the assignee for the bug.=