From owner-freebsd-bugs Fri Jun 1 18: 0: 6 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 7BCD237B424 for ; Fri, 1 Jun 2001 18:00:03 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f52103M69348; Fri, 1 Jun 2001 18:00:03 -0700 (PDT) (envelope-from gnats) Date: Fri, 1 Jun 2001 18:00:03 -0700 (PDT) Message-Id: <200106020100.f52103M69348@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Glenn Trewitt Subject: Re: bin/24136: sysinstall's install.cfg tryRTSOL and tryDHCP don't work Reply-To: Glenn Trewitt Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/24136; it has been noted by GNATS. From: Glenn Trewitt To: freebsd-gnats-submit@FreeBSD.org, gordont@bluemtn.net Cc: Subject: Re: bin/24136: sysinstall's install.cfg tryRTSOL and tryDHCP don't work Date: Fri, 01 Jun 2001 17:51:57 -0700 I just ran across the same bug. I think that I found the more basic problem. In tcpip.c, the code that tests the value of tryDHCP (and tryRTSOL) has the test backwards when checking for the "NO" value. In the code: if (!variable_cmp(VAR_TRY_DHCP, "YES") || ((!variable_cmp(VAR_TRY_DHCP, "NO")) && (!msgNoYes("Do you want to try DHCP configuration of the interface?")))) { should be if (!variable_cmp(VAR_TRY_DHCP, "YES") || ((variable_cmp(VAR_TRY_DHCP, "NO")) && (!msgNoYes("Do you want to try DHCP configuration of the interface?")))) { I think that this addresses the underlying problem. (This also explains why setting tryDHCP to anything besides "YES" or "NO" has the effect expected for tryDHCP=NO. - Glenn Trewitt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message