From owner-freebsd-bugs  Mon Apr 12 23:42:20 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 9B6211521D
	for <freebsd-bugs@FreeBSD.org>; Mon, 12 Apr 1999 23:42:19 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.2/8.9.2) id XAA58076;
	Mon, 12 Apr 1999 23:40:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 78FD714D3B; Mon, 12 Apr 1999 23:35:27 -0700 (PDT)
Message-Id: <19990413063527.78FD714D3B@hub.freebsd.org>
Date: Mon, 12 Apr 1999 23:35:27 -0700 (PDT)
From: toh@victoria.tc.ca
To: freebsd-gnats-submit@freebsd.org
X-Send-Pr-Version: www-1.0
Subject: kern/11109: ipfw.ko Makefile contains CFLAGS+= -DDIVERT when it probably means -DIPDIVERT
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         11109
>Category:       kern
>Synopsis:       ipfw.ko Makefile contains CFLAGS+= -DDIVERT when it probably means -DIPDIVERT
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 12 23:40:00 PDT 1999
>Closed-Date:
>Last-Modified:
>Originator:     Marc Sira
>Release:        3.1-RELEASE
>Organization:
>Environment:
FreeBSD tempo 3.1-RELEASE...i386
>Description:
The ipfw.ko module in 3.1-RELEASE doesn't include support for divert sockets, which prevents it being used with natd. The Makefile in /sys/modules/ipfw contains "CFLAGS+= -DDIVERT", but that macro doesn't exist in any source file. It seems likely that someone (peter) wanted to enable divert sockets (which is a good idea), and meant to type "CFLAGS+= -IPDIVERT" instead (since that macro is used in the appropriate #ifdefs within ipfw.c). Fixing this (and the compiled module in the distribution, obviously) will make it easier for people to do NAT without compiling a new kernel, possibly even from the GENERIC kernel.
>How-To-Repeat:
$ kldload ipfw
IP packet filtering initialized, divert disabled, ...

>Fix:
sed 's/-DDIVERT/-DIPDIVERT/' Makefile


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message