From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb 20 03:20:01 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 817432CB
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed, 20 Feb 2013 03:20:01 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 50B9DCCC
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed, 20 Feb 2013 03:20:01 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r1K3K1fU059570
 for <freebsd-bugs@freefall.freebsd.org>; Wed, 20 Feb 2013 03:20:01 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r1K3K1j8059569;
 Wed, 20 Feb 2013 03:20:01 GMT (envelope-from gnats)
Resent-Date: Wed, 20 Feb 2013 03:20:01 GMT
Resent-Message-Id: <201302200320.r1K3K1j8059569@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Marcelo Araujo <araujo@FreeBSD.org>
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id E3815270
 for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Feb 2013 03:13:26 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id 8D793C2F
 for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Feb 2013 03:13:26 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r1K3DQua071062
 for <freebsd-gnats-submit@FreeBSD.org>; Wed, 20 Feb 2013 03:13:26 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id r1K3DQaC071061;
 Wed, 20 Feb 2013 03:13:26 GMT (envelope-from nobody)
Message-Id: <201302200313.r1K3DQaC071061@red.freebsd.org>
Date: Wed, 20 Feb 2013 03:13:26 GMT
From: Marcelo Araujo <araujo@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: kern/176280: [kernel] On net/if_var.h we can't return a value in a
 void function.
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Feb 2013 03:20:01 -0000


>Number:         176280
>Category:       kern
>Synopsis:       [kernel] On net/if_var.h we can't return a value in a void function.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 20 03:20:01 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     Marcelo Araujo
>Release:        9.1-RELEASE
>Organization:
FreeBSD
>Environment:
FreeBSD qnap91 9.1-RELEASE FreeBSD 9.1-RELEASE #0: Tue Jan 22 11:03:23 CST 2013     root@qnap91:/usr/obj/usr/src/sys/QNAP  amd64
>Description:
On FreeBSD-HEAD specifically on sys/net/if_var.h at line 695 on the function drbr_advance we cannot call a return in a void function, we should use the mbuf struct.
>How-To-Repeat:
Build it using clang.
>Fix:


Patch attached with submission follows:

--- sys/net/if_var.h	2013-02-19 10:54:20.065079344 +0800
+++ /tmp/b	2013-02-20 11:07:26.009262919 +0800
@@ -695,7 +695,7 @@
 	return (buf_ring_dequeue_sc(br));
 }
 
-static __inline void
+static __inline int 
 drbr_advance(struct ifnet *ifp, struct buf_ring *br)
 {
 #ifdef ALTQ


>Release-Note:
>Audit-Trail:
>Unformatted: