From owner-svn-src-head@freebsd.org  Thu Dec 15 07:06:37 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AC0C6C8162E
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Thu, 15 Dec 2016 07:06:37 +0000 (UTC) (envelope-from
 0100015901493368-65fc1bf5-524a-437b-960d-21010488a7c1-000000@amazonses.com)
Received: from a8-26.smtp-out.amazonses.com (a8-26.smtp-out.amazonses.com
 [54.240.8.26])
 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 7093A1C5B
 for <svn-src-head@freebsd.org>; Thu, 15 Dec 2016 07:06:37 +0000 (UTC)
 (envelope-from
 0100015901493368-65fc1bf5-524a-437b-960d-21010488a7c1-000000@amazonses.com)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple;
 s=vnqrkfnvu6csdl6mwgk5t6ix3nnepx57; d=tarsnap.com; t=1481785291;
 h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
 bh=N3n/iMMf7NYHRWE+S/0sjONA/JY4EvmSgiu8rJAjNYU=;
 b=jGYfZdE3MEkHQLYXL6QINX/q09bIq3MR2e/XCA5DIzM2VR7A3g8Pp6qqkf+cfTT/
 AAWHvsXC1FGuYr+aiDKR3D27HXx3Wv5WRu0GWDdoMUhwF5uneVIAEkoytY2+8qOhObJ
 bBOyoHlE67YDcgAjvP9nnMUMo7ypymA/B/JeK86Y=
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple;
 s=6gbrjpgwjskckoa6a5zn6fwqkn67xbtw; d=amazonses.com; t=1481785291;
 h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID;
 bh=N3n/iMMf7NYHRWE+S/0sjONA/JY4EvmSgiu8rJAjNYU=;
 b=fTWTacu/FpwZLuPf/NuBFy5aeDnekApHZvzVJa32ep0IgcM3cssuhFpnBzV6/jlS
 Ls9V8C7ZUWUYiISbJbWtt/rS8yKS9OmtpcjigzNmhH8L/eBF/5Sad/w3k55eAYWoppY
 EkbCAr/GocqEAmTvnP70miKhljyUmqcFL3E/SQ/k=
Subject: Re: svn commit: r310086 - head/sys/dev/xen/blkfront
To: Dimitry Andric <dim@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
References: <201612141928.uBEJSJor074348@repo.freebsd.org>
From: Colin Percival <cperciva@tarsnap.com>
Message-ID: <0100015901493368-65fc1bf5-524a-437b-960d-21010488a7c1-000000@email.amazonses.com>
Date: Thu, 15 Dec 2016 07:01:31 +0000
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.0
MIME-Version: 1.0
In-Reply-To: <201612141928.uBEJSJor074348@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SES-Outgoing: 2016.12.15-54.240.8.26
Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Dec 2016 07:06:37 -0000

On 12/14/16 11:28, Dimitry Andric wrote:
> Log:
>   In xbd_connect(), use correct scanf conversion specifiers for the
>   feature_barrier and feature_flush variables.  Otherwise, adjacent
>   variables on the stack, such as sector_size, may be overwritten, with
>   disastrous results.

Thanks!  Did you happen to notice what stack variable (if any?) was being
overwritten under clang 3.8.0?  Just wondering if there might be some
undiscovered issue lurking in FreeBSD releases which will cause other less
obvious problems.

-- 
Colin Percival
Security Officer Emeritus, FreeBSD | The power to serve
Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid