From owner-freebsd-xfce@freebsd.org Sat Oct 17 22:09:23 2020 Return-Path: Delivered-To: freebsd-xfce@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F0B4F443361 for ; Sat, 17 Oct 2020 22:09:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4CDHHR68q1z3Rr5 for ; Sat, 17 Oct 2020 22:09:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id D347D443360; Sat, 17 Oct 2020 22:09:23 +0000 (UTC) Delivered-To: xfce@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D205444335E for ; Sat, 17 Oct 2020 22:09:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CDHHR5JCkz4gKX for ; Sat, 17 Oct 2020 22:09:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 9ADD2896E for ; Sat, 17 Oct 2020 22:09:23 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 09HM9Nl9084305 for ; Sat, 17 Oct 2020 22:09:23 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 09HM9Nfj084304 for xfce@FreeBSD.org; Sat, 17 Oct 2020 22:09:23 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: xfce@FreeBSD.org Subject: [Bug 250311] devel/glib20: lock getfsent() usage to fix x11-fm/thunar crashes Date: Sat, 17 Oct 2020 22:09:23 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: rozhuk.im@gmail.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: fluffy@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2020 22:09:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D250311 --- Comment #10 from rozhuk.im@gmail.com --- I dig inside this. #5 0x000000080a181da9 in g_unix_mount_point_at () at /usr/local/lib/libgio-2.0.so.0 #6 0x000000080a1e0811 in () at /usr/local/lib/libgio-2.0.so.0 - ignore_trash_mount() #7 0x000000080a1e0624 in () at /usr/local/lib/libgio-2.0.so.0 - ignore_trash_path() #8 0x000000080a1e4235 in () at /usr/local/lib/libgio-2.0.so.0 - g_local_file_trash() / _g_local_file_has_trash_dir() #9 0x000000080a1e3d4e in () at /usr/local/lib/libgio-2.0.so.0 - some proxy staff #10 0x000000080a116a88 in g_file_enumerator_next_file () at /usr/local/lib/libgio-2.0.so.0 This code path check is "x-gvfs-notrash" present in mount options. As for me, better to patch this: GList * g_unix_mount_points_get (guint64 *time_read) { if (time_read) *time_read =3D get_mount_points_timestamp (); return _g_get_unix_mount_points (); } add lock and cache. --=20 You are receiving this mail because: You are on the CC list for the bug.=