From owner-freebsd-ports-bugs@FreeBSD.ORG Fri May 29 18:25:44 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 335B0F33 for ; Fri, 29 May 2015 18:25:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 166441A49 for ; Fri, 29 May 2015 18:25:44 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t4TIPhKQ087785 for ; Fri, 29 May 2015 18:25:43 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199081] [revive port] mail/smfsav: Add staging support Date: Fri, 29 May 2015 18:25:44 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: amdmi3@FreeBSD.org X-Bugzilla-Status: Open X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: amdmi3@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status assigned_to Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2015 18:25:44 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199081 Dmitry Marakasov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open Assignee|freebsd-ports-bugs@FreeBSD. |amdmi3@FreeBSD.org |org | --- Comment #6 from Dmitry Marakasov --- Why don't we change user name to "smfs" which is upstream default? # Run as a selected user (smf-sav must be started by root) # # Default: smfs Also I suggest the following set of changes: - Add LICENSE_FILE - Use -lpthread as threading ldflags as it has been decided - Simplify installation - no need to split do-install and post-install, do need to install docs conditionally as this is handled automatically diff -ruN smfsav.orig/Makefile smfsav/Makefile --- smfsav.orig/Makefile 2015-05-29 21:20:18.470625000 +0300 +++ smfsav/Makefile 2015-05-29 21:15:04.043203000 +0300 @@ -13,18 +13,17 @@ COMMENT= Sendmail Sender Address Validator LICENSE= GPLv2 +LICENSE_FILE= ${WRKSRC}/COPYING USERS= smfsav GROUPS= smfsav OPTIONS_DEFINE= DOCS -.include - USE_RC_SUBR= smfsav CPPFLAGS+= -D_REENTRANT -LDFLAGS+= -lmilter -pthread +LDFLAGS+= -lmilter -lpthread SMFSAV_RUN_DIR?=/var/run/smfsav SUB_FILES+= pkg-message @@ -38,12 +37,8 @@ do-install: ${INSTALL_PROGRAM} ${WRKSRC}/smf-sav ${STAGEDIR}${PREFIX}/sbin/smfsav ${INSTALL_DATA} ${WRKSRC}/smf-sav.conf ${STAGEDIR}${PREFIX}/etc/smfsav.conf.sample - -post-install: @${MKDIR} ${STAGEDIR}${SMFSAV_RUN_DIR} -.if ${PORT_OPTIONS:MDOCS} @${MKDIR} ${STAGEDIR}${DOCSDIR} cd ${WRKSRC} && ${INSTALL_DATA} ChangeLog readme ${STAGEDIR}${DOCSDIR} -.endif .include diff -ruN smfsav.orig/files/pkg-message.in smfsav/files/pkg-message.in --- smfsav.orig/files/pkg-message.in 2015-05-29 21:20:18.464386000 +0300 +++ smfsav/files/pkg-message.in 2015-05-29 21:12:35.276515000 +0300 @@ -5,5 +5,5 @@ define(`confMILTER_MACROS_HELO', confMILTER_MACROS_HELO`, {verify}')dnl INPUT_MAIL_FILTER(`smfsav', `S=unix:/var/run/smfsav/smfsav.sock, T=S:30s;R:4m')dnl 3. Put line smfsav_enable="YES" to /etc/rc.conf file -4. Run service smfsav start +4. Run `service smfsav start` ===================================================================================== -- You are receiving this mail because: You are the assignee for the bug.