From owner-svn-src-head@FreeBSD.ORG Mon Jul 9 08:09:49 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 06B261065670; Mon, 9 Jul 2012 08:09:49 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 9F9038FC12; Mon, 9 Jul 2012 08:09:46 +0000 (UTC) Received: from alph.allbsd.org (p2214-ipbf2707funabasi.chiba.ocn.ne.jp [123.225.119.214]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id q6989Lfn035646 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 9 Jul 2012 17:09:35 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id q6989J8u070102; Mon, 9 Jul 2012 17:09:20 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Mon, 09 Jul 2012 17:08:13 +0900 (JST) Message-Id: <20120709.170813.339720376082380726.hrs@allbsd.org> To: melifaro@FreeBSD.org From: Hiroki Sato In-Reply-To: <4FFA894D.9050104@FreeBSD.org> References: <201207090716.q697GJ7A001973@svn.freebsd.org> <4FFA894D.9050104@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Mon_Jul__9_17_08_13_2012_866)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Mon, 09 Jul 2012 17:09:36 +0900 (JST) X-Spam-Status: No, score=-96.8 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT, RCVD_IN_RP_RNBL, SAMEHELOBY2HOP, USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r238277 - in head: etc/defaults etc/rc.d sbin/ipfw share/man/man5 sys/netinet/ipfw X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jul 2012 08:09:49 -0000 ----Security_Multipart(Mon_Jul__9_17_08_13_2012_866)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit "Alexander V. Chernikov" wrote in <4FFA894D.9050104@FreeBSD.org>: me> On 09.07.2012 11:16, Hiroki Sato wrote: me> > Author: hrs me> > Date: Mon Jul 9 07:16:19 2012 me> > New Revision: 238277 me> > URL: http://svn.freebsd.org/changeset/base/238277 me> > me> > Log: me> > Make ipfw0 logging pseudo-interface clonable. It can be created me> > automatically me> > by $firewall_logif rc.conf(5) variable at boot time or manually by me> > ifconfig(8) me> > after a boot. me> > me> > Discussed on: freebsd-ipfw@ me> Em, well, I thought "discussed" means some kind of consensus? me> There was an alternative implementation proposed in -ipfw with no me> comments from you side. Additionally, there can be other (still not me> discussed) solutions like making this interface as loadable module me> (like pf do). I meant there was no strong objection. I am sorry for not commenting your implementation, but at least for ipfw0 it is difficult to decouple ifnet and bpf because the primary consumer is tcpdump(8), which depends on NET_RT_IFLIST to find the target. Probably your solution can be used for usbdump(8). The reason why I committed the patch now is there are reports that these pseudo interfaces made some applications confused and/or caused some performance degradation on 9.0R, and wanted to fix it in some way. I am still open for more sophisticated implementation and have no objection to replace mine with it. Do you have an idea about converting it with a loadable module? -- Hiroki ----Security_Multipart(Mon_Jul__9_17_08_13_2012_866)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEABECAAYFAk/6kW0ACgkQTyzT2CeTzy2FygCgkA6HqiidVRcLOgXBA+Aipi3H Vp4AoNE4Tfbhmi4xE3n/IzPe1+K9jr65 =Qzyy -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Jul__9_17_08_13_2012_866)----