From nobody Tue Jan 13 21:31:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4drMrf1N9zz6NkB3 for ; Tue, 13 Jan 2026 21:31:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4drMrf0hlrz3HCR for ; Tue, 13 Jan 2026 21:31:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768339906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IULkRWL7a66ufxh8kZDmQFsNcsqBS0JWLW3uJhRzeEo=; b=lbFMsfBuKJKMIllXll/jP9okM368nXG0c1X7Vf8dIKafNLjDcrAKEakmzgp9LbYo1dM79N 24vLwNZm1rsV2YBmLW2eauoRDHLRB9znmitJrjDFQ8HXccAKzR9amCkSc18wKwGNGoba/g jfm9VveWsp6o8QrqMMudeKIM2lHX5QNeQWlofPBfSfp/luPwPoxSmU4xhJ3FX/ajVeyDjx dbOWUwhFcsPZ+urlmQJRwgPB+Dq1ocYcFTTlRlgANHSu2DLjl2/Rb2Fq8w9LDSiXDbwdek 6Qrp0na6YNrHi/CyD+WjEQBeBaYPTSjrsAJoAiL9hMIX10Xu4CKebOD6P5bEcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1768339906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IULkRWL7a66ufxh8kZDmQFsNcsqBS0JWLW3uJhRzeEo=; b=o3MQ73S9DyN1wdtBV7VQSgSmiC7shjM3jj8qyAhMUrc3HdqrucVGg+lZavkQDnP2dI5Snl m/gd/ezaK5pAjewDERG/lJVjvCRFCGTD9w++syLj9o01HHjagbVgD3sPrFUYPsB6fg9b4R pOIOquDEQP84ojLbCjCxhBenDv6U+KUeJhgVAkOIDdoXTn8NR2sszEEuhRtNM/wPxUBd/S 1cHH/8zc1gOUJcP7jcHgMsOYGzc2diyBAl/ygzuugo/6/dGNT13K7ZYUApKuUWS7NA9Qr0 UC0vn5Tca/B99d7WUA/EOScndB9Ba695Sc5JuYb3GTYocnKw9hoyg46IVwmcCQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1768339906; a=rsa-sha256; cv=none; b=ChmD+xnUktKTlKa0tpMOK7cDp6ygmg2M9283duEBzKagihGTat662M/VlYcukGGb6ioE5n q3ftC25Dz/uzCPWPGoUq+wS9XLrWsb4colFNxI1wS5+ataLZnyQIYwqxMDNrEOmsxZIo1S 03RukFdPlekpiRLZTnt/5tmM3/TWhmtuzS7pfI8ayQNN+gkYzp9x5Zu51CNn4J+JVj2f49 17X/ZEql1/qb+BzEVwWWViTIwLoulsNSM3l1XGH/uLLVSn+fYg+GdFkEmhCX/JqO/MixmN SrdVLy5bTpW+5wHlpEF23EMALFzxndJFBooReJc64ALGhumubeRQwROLvg67bg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4drMrf09CczTrk for ; Tue, 13 Jan 2026 21:31:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 26d9c by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 13 Jan 2026 21:31:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: e8348e2b35f3 - main - enc: create an interface at SI_SUB_PROTO_IF stage List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e8348e2b35f3f644c391b8e0585090c451896684 Auto-Submitted: auto-generated Date: Tue, 13 Jan 2026 21:31:45 +0000 Message-Id: <6966b9c1.26d9c.8073fc@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=e8348e2b35f3f644c391b8e0585090c451896684 commit e8348e2b35f3f644c391b8e0585090c451896684 Author: Gleb Smirnoff AuthorDate: 2026-01-09 23:31:11 +0000 Commit: Gleb Smirnoff CommitDate: 2026-01-13 21:30:22 +0000 enc: create an interface at SI_SUB_PROTO_IF stage Creation of enc0 before SI_SUB_PROTO_MC mangles the MLD list as well as encounters IGMP mutex not initialized yet. Reported & tested by: mjg NB: the enc(4) is not a true interface indeed. In a perfect world the module shall not create a cloner, shall not enter if_attach(), shall not trigger ifnet_arrival_event, neither shall have any protocol attached to it. The enc0 exists for two purposes: 1) create a bpf(9) tap; 2) to allow injection packets in the middle of ipsec(4) processing temporarily rewriting m_pkthdr.rcvif to point at enc0. While the problem 1 is already solved with a recent divorce between bpf(9) and ifnet(9), the problem 2 is harder to solve without breaking packet filter rules that use "via enc0". --- sys/net/if_enc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/net/if_enc.c b/sys/net/if_enc.c index 3c3f19661063..159fb3ca34c9 100644 --- a/sys/net/if_enc.c +++ b/sys/net/if_enc.c @@ -387,7 +387,7 @@ vnet_enc_init(const void *unused __unused) ifc_create_ifp(encname, &ifd, &ifp); V_enc_sc = ifp->if_softc; } -VNET_SYSINIT(vnet_enc_init, SI_SUB_PSEUDO, SI_ORDER_ANY, +VNET_SYSINIT(vnet_enc_init, SI_SUB_PROTO_IF, SI_ORDER_ANY, vnet_enc_init, NULL); static void