From owner-cvs-all@FreeBSD.ORG Tue Jan 31 15:39:17 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9884816A4DD; Tue, 31 Jan 2006 15:39:17 +0000 (GMT) (envelope-from marius@newtrinity.zeist.de) Received: from newtrinity.zeist.de (newtrinity.zeist.de [217.24.217.8]) by mx1.FreeBSD.org (Postfix) with ESMTP id CD59943D45; Tue, 31 Jan 2006 15:39:16 +0000 (GMT) (envelope-from marius@newtrinity.zeist.de) Received: from newtrinity.zeist.de (localhost [127.0.0.1]) by newtrinity.zeist.de (8.12.11/8.12.11/ZEIST.DE) with ESMTP id k0VFdEsp040910; Tue, 31 Jan 2006 16:39:15 +0100 (CET) (envelope-from marius@newtrinity.zeist.de) Received: (from marius@localhost) by newtrinity.zeist.de (8.12.11/8.12.10/Submit) id k0VFd98a040909; Tue, 31 Jan 2006 16:39:09 +0100 (CET) (envelope-from marius) Date: Tue, 31 Jan 2006 16:39:09 +0100 From: Marius Strobl To: Scott Long Message-ID: <20060131163909.E68720@newtrinity.zeist.de> References: <200601311448.k0VEmwVF043100@repoman.freebsd.org> <43DF7BE5.4050609@samsco.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <43DF7BE5.4050609@samsco.org>; from scottl@samsco.org on Tue, Jan 31, 2006 at 08:01:57AM -0700 X-AntiVirus-modified: yes X-AntiVirus: checked by AntiVir Milter (version: 1.1.2-1; AVE: 6.33.0.31; VDF: 6.33.0.177; host: newtrinity.zeist.de) Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/le am7990.c am79900.c am79900reg.h am79900var.h am7990reg.h am7990var.h if_le_ledma.c if_le_pci.c lance.c lancereg.h lancevar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jan 2006 15:39:18 -0000 On Tue, Jan 31, 2006 at 08:01:57AM -0700, Scott Long wrote: > Marius Strobl wrote: > > marius 2006-01-31 14:48:58 UTC > > > > FreeBSD src repository > > > > Added files: > > sys/dev/le am7990.c am79900.c am79900reg.h > > am79900var.h am7990reg.h am7990var.h > > if_le_ledma.c if_le_pci.c lance.c > > lancereg.h lancevar.h > > Log: > > Add le(4), a driver for AMD Am7900 LANCE and Am79C9xx PCnet NICs ported > > from NetBSD. This driver actually can replace lnc(4). Advantages over > > lnc(4) are: > > - Cleaner and more flexible regarding MD needs. > > - Endian-clean and MPSAFE. > > - Supports ALTQ, VLAN_MTU, ifmedia. > > - Uses 32bit DMA for the PCI variants. > > > > This commit includes front-ends for the dma(4) pseudo-bus found on SBus- > > based sparc64 machines (thus supports the on-board LANCE in Sun Ultra 1) > > and PCI. In order to actually replace lnc(4), the front-ends for ISA and > > the PC98 CBUS would have to be added but for which I don't have hardware > > to test. > > > > Reviewed and some improvements by: yongari > > Tested on: i386, sparc64 > > > > Excellent job! One question, though. I believe that VMWare emulates > Lance hardware. If your new le driver works on that, then I see no > reason to not disable the lnc driver and enable the le driver by > default. > The NetBSD version is known to work with the VMWare LANCE (it actually also has the same workaround as lnc(4) for a bug in the emulation) so I think the ported version also will. I haven't given that a try so far however and only tested it with real PCI hardware as my main goal is to get it into RELENG_6 as soon as possible in order to get it into 6.1 (without replacing lnc(4) in the default config). If someone could give it a try with VMWare so I don't need to get a copy and probably a Windows installation that would be really great though. My plan is to let le(4) replace lnc(4) in the mid term however. Regarding getting it into RELENG_6 for inclusion in 6.1 what time for the MFC would you prefer from the re@ point of view? Marius -- This mail was scanned by AntiVir Milter. This product is licensed for non-commercial use. See www.antivir.de for details.