From owner-freebsd-current  Sun Feb 24 13:30:48 2002
Delivered-To: freebsd-current@freebsd.org
Received: from etek.chalmers.se (quarl0.etek.chalmers.se [129.16.32.20])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1C63837B416; Sun, 24 Feb 2002 13:30:45 -0800 (PST)
Received: from downy.etek.chalmers.se (_7-268@downy.etek.chalmers.se [129.16.32.207])
	by etek.chalmers.se (8.10.0/8.8.8) with ESMTP id g1OLUhV02989;
	Sun, 24 Feb 2002 22:30:43 +0100 (MET)
Received: from localhost (b@localhost)
	by downy.etek.chalmers.se (8.10.0/8.10.0) with ESMTP id g1OLUhk10826;
	Sun, 24 Feb 2002 22:30:43 +0100 (MET)
Date: Sun, 24 Feb 2002 22:30:42 +0100 (MET)
From: Magnus B{ckstr|m <b@etek.chalmers.se>
To: Michael Smith <msmith@freebsd.org>
Cc: current@freebsd.org
Subject: Re: HEADS UP: ACPI CA updated
In-Reply-To: <200202242018.g1OKIUG00719@mass.dis.org>
Message-ID: <Pine.OSF.4.40.0202242227330.15157-100000@downy.etek.chalmers.se>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Sun, 24 Feb 2002, Michael Smith wrote:
> Try grabbing Giant in acpi_tz_thread when it wakes up, then dropping it
> again before it goes to sleep.  This is probably a hack, but I'd guess a
> required one for now.
>
> If that works, send me a diff and I'll commit it with thanks!

Yow!  Works absolutely fine.  Patch below!

Thanks!
Magnus

--- sys/dev/acpica/acpi_thermal.c.ctm	Sun Feb 24 13:55:13 2002
+++ sys/dev/acpica/acpi_thermal.c	Sun Feb 24 23:20:39 2002
@@ -31,6 +31,8 @@
 #include <sys/param.h>
 #include <sys/kernel.h>
 #include <sys/kthread.h>
+#include <sys/lock.h>
+#include <sys/mutex.h>
 #include <sys/bus.h>
 #include <sys/proc.h>
 #include <sys/reboot.h>
@@ -780,6 +782,8 @@
     for (;;) {
 	tsleep(&acpi_tz_proc, PZERO, "nothing", hz * acpi_tz_polling_rate);

+	mtx_lock(&Giant);
+
 	if (devcount == 0)
 	    devclass_get_devices(acpi_tz_devclass, &devs, &devcount);

@@ -787,5 +791,7 @@
 	for (i = 0; i < devcount; i++)
 	    acpi_tz_timeout(device_get_softc(devs[i]));
 	ACPI_UNLOCK;
+
+	mtx_unlock(&Giant);
     }
 }


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message