From nobody Sun Sep 4 21:36:47 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MLQ2p5ZyTz4bh1c for ; Sun, 4 Sep 2022 21:36:50 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MLQ2p1MMcz3W6t for ; Sun, 4 Sep 2022 21:36:50 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f51.google.com with SMTP id bp20so8537835wrb.9 for ; Sun, 04 Sep 2022 14:36:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=2Ldto2hg2e7hLnyvKmCmWoVCxEmhSOV84Ba1CFPHAr4=; b=bCRWzUDzVn7Th1VH8sUsIlYEQaedh9W+9GP+jwH9aWtpmeWh2E2iz6yW1+gym0yD1v yDUKmIQ0Hh2A1XdUzs3m536mul54yg6Xwl8w65i4XFqXLXt1D3pPjYkrPFrNNAUoIOYw ocdh2Ka9Rf9/YVCqztxyhlDRoiJbptvTSjkMV6VS74l/B+5uYN/fK5atsaHLC9pTCYvC 4aJcY4SednjECoUeWsEFpP8HycNG39esFQg9GAsywFY8yriIpv8RjSqdzR2/8Mks487s POXHa0r+aw1gchc2pGImi27aTLFf9xD3Im9rbbTNhaExeMKFEoYGDoXAXt19qnx+nx7Q DmQw== X-Gm-Message-State: ACgBeo0+Y2w8z0eOSb55gTots9Dn50K+ASRTl34yFQYa0GyKUb9L3sQa aHenixRXKi1mIIhXJeG04KBr7Q== X-Google-Smtp-Source: AA6agR6rHTkPlJ2+kLJvGoOvXau91SxMKk7ct4G93Z6iiPAyUC9fwQ9OGs8NAkrBqKIPO63MRzDzsQ== X-Received: by 2002:a5d:6d0b:0:b0:222:764d:9e98 with SMTP id e11-20020a5d6d0b000000b00222764d9e98mr21859960wrq.189.1662327408741; Sun, 04 Sep 2022 14:36:48 -0700 (PDT) Received: from smtpclient.apple (global-5-141.n-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id t14-20020a5d534e000000b0022511d35d5bsm7091793wrv.12.2022.09.04.14.36.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 04 Sep 2022 14:36:48 -0700 (PDT) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\)) Subject: Re: git: 8ca67bf1273a - main - usb: Remove a double words in a source code comments From: Jessica Clarke In-Reply-To: <202209041540.284FeabC070627@gitrepo.freebsd.org> Date: Sun, 4 Sep 2022 22:36:47 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202209041540.284FeabC070627@gitrepo.freebsd.org> To: Gordon Bergling X-Mailer: Apple Mail (2.3696.80.82.1.1) X-Rspamd-Queue-Id: 4MLQ2p1MMcz3W6t X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of jrtc27@jrtc27.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=jrtc27@jrtc27.com X-Spamd-Result: default: False [-2.50 / 15.00]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MV_CASE(0.50)[]; FORGED_SENDER(0.30)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; MIME_GOOD(-0.10)[text/plain]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_DN_EQ_ADDR_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; RCVD_IN_DNSWL_NONE(0.00)[209.85.221.51:from]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FREEFALL_USER(0.00)[jrtc27]; ARC_NA(0.00)[]; FROM_NEQ_ENVFROM(0.00)[jrtc27@freebsd.org,jrtc27@jrtc27.com]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; R_DKIM_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.221.51:from] X-ThisMailContainsUnwantedMimeParts: N On 4 Sept 2022, at 16:40, Gordon Bergling wrote: >=20 > The branch main has been updated by gbe (doc committer): >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D8ca67bf1273a5168f8a3787183159c47= 7632e582 >=20 > commit 8ca67bf1273a5168f8a3787183159c477632e582 > Author: Gordon Bergling > AuthorDate: 2022-09-04 15:40:25 +0000 > Commit: Gordon Bergling > CommitDate: 2022-09-04 15:40:25 +0000 >=20 > usb: Remove a double words in a source code comments >=20 > - s/that that/that/ >=20 > MFC after: 3 days > --- > sys/dev/usb/net/if_muge.c | 2 +- > sys/dev/usb/net/if_smsc.c | 2 +- > sys/dev/usb/usb_busdma.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/sys/dev/usb/net/if_muge.c b/sys/dev/usb/net/if_muge.c > index 3087eb40b40a..c705fcd56eed 100644 > --- a/sys/dev/usb/net/if_muge.c > +++ b/sys/dev/usb/net/if_muge.c > @@ -1556,7 +1556,7 @@ muge_set_leds(struct usb_ether *ue) > * @ue: the USB ethernet device > * > * This is where the chip is intialised for the first time. This = is > - * different from the muge_init() function in that that one is = designed to > + * different from the muge_init() function in that one is designed = to The original comment was correct; changing it loses a key part. > * setup the H/W to match the UE settings and can be called after a = reset. > * > */ > diff --git a/sys/dev/usb/net/if_smsc.c b/sys/dev/usb/net/if_smsc.c > index e3b4ae9a5cbd..c34cc85269cc 100644 > --- a/sys/dev/usb/net/if_smsc.c > +++ b/sys/dev/usb/net/if_smsc.c > @@ -1545,7 +1545,7 @@ smsc_ioctl(struct ifnet *ifp, u_long cmd, = caddr_t data) > * @ue: the USB ethernet device > * > * This is where the chip is intialised for the first time. This = is different > - * from the smsc_init() function in that that one is designed to = setup the > + * from the smsc_init() function in that one is designed to setup = the Ditto. Jess > * H/W to match the UE settings and can be called after a reset. > * > * > diff --git a/sys/dev/usb/usb_busdma.c b/sys/dev/usb/usb_busdma.c > index 62e22805b39c..69d9ea292523 100644 > --- a/sys/dev/usb/usb_busdma.c > +++ b/sys/dev/usb/usb_busdma.c > @@ -546,7 +546,7 @@ usb_pc_alloc_mem(struct usb_page_cache *pc, struct = usb_page *pg, > /* > * XXX BUS-DMA workaround - FIXME later: > * > - * We assume that that the alignment at this point of > + * We assume that the alignment at this point of > * the code is greater than or equal to the size and > * less than two times the size, so that if we double > * the size, the size will be greater than the