Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 4 Sep 2022 22:36:47 +0100
From:      Jessica Clarke <jrtc27@freebsd.org>
To:        Gordon Bergling <gbe@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: 8ca67bf1273a - main - usb: Remove a double words in a source code comments
Message-ID:  <A5CC6408-2DC6-4AB5-A9C4-0D6281408F79@freebsd.org>
In-Reply-To: <202209041540.284FeabC070627@gitrepo.freebsd.org>
References:  <202209041540.284FeabC070627@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 4 Sept 2022, at 16:40, Gordon Bergling <gbe@FreeBSD.org> wrote:
>=20
> The branch main has been updated by gbe (doc committer):
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3D8ca67bf1273a5168f8a3787183159c47=
7632e582
>=20
> commit 8ca67bf1273a5168f8a3787183159c477632e582
> Author:     Gordon Bergling <gbe@FreeBSD.org>
> AuthorDate: 2022-09-04 15:40:25 +0000
> Commit:     Gordon Bergling <gbe@FreeBSD.org>
> CommitDate: 2022-09-04 15:40:25 +0000
>=20
>    usb: Remove a double words in a source code comments
>=20
>    - s/that that/that/
>=20
>    MFC after:      3 days
> ---
> sys/dev/usb/net/if_muge.c | 2 +-
> sys/dev/usb/net/if_smsc.c | 2 +-
> sys/dev/usb/usb_busdma.c  | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/sys/dev/usb/net/if_muge.c b/sys/dev/usb/net/if_muge.c
> index 3087eb40b40a..c705fcd56eed 100644
> --- a/sys/dev/usb/net/if_muge.c
> +++ b/sys/dev/usb/net/if_muge.c
> @@ -1556,7 +1556,7 @@ muge_set_leds(struct usb_ether *ue)
>  *	@ue: the USB ethernet device
>  *
>  *	This is where the chip is intialised for the first time.  This =
is
> - *	different from the muge_init() function in that that one is =
designed to
> + *	different from the muge_init() function in that one is designed =
to

The original comment was correct; changing it loses a key part.

>  *	setup the H/W to match the UE settings and can be called after a =
reset.
>  *
>  */
> diff --git a/sys/dev/usb/net/if_smsc.c b/sys/dev/usb/net/if_smsc.c
> index e3b4ae9a5cbd..c34cc85269cc 100644
> --- a/sys/dev/usb/net/if_smsc.c
> +++ b/sys/dev/usb/net/if_smsc.c
> @@ -1545,7 +1545,7 @@ smsc_ioctl(struct ifnet *ifp, u_long cmd, =
caddr_t data)
>  *	@ue: the USB ethernet device
>  *
>  *	This is where the chip is intialised for the first time.  This =
is different
> - *	from the smsc_init() function in that that one is designed to =
setup the
> + *	from the smsc_init() function in that one is designed to setup =
the

Ditto.

Jess

>  *	H/W to match the UE settings and can be called after a reset.
>  *
>  *
> diff --git a/sys/dev/usb/usb_busdma.c b/sys/dev/usb/usb_busdma.c
> index 62e22805b39c..69d9ea292523 100644
> --- a/sys/dev/usb/usb_busdma.c
> +++ b/sys/dev/usb/usb_busdma.c
> @@ -546,7 +546,7 @@ usb_pc_alloc_mem(struct usb_page_cache *pc, struct =
usb_page *pg,
> 		/*
> 		 * XXX BUS-DMA workaround - FIXME later:
> 		 *
> -		 * We assume that that the alignment at this point of
> +		 * We assume that the alignment at this point of
> 		 * the code is greater than or equal to the size and
> 		 * less than two times the size, so that if we double
> 		 * the size, the size will be greater than the




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A5CC6408-2DC6-4AB5-A9C4-0D6281408F79>