From owner-svn-src-all@freebsd.org Wed Jan 22 21:13:14 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 310331FDD61; Wed, 22 Jan 2020 21:13:14 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from forward500p.mail.yandex.net (forward500p.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 482ymp03QCz4Y6n; Wed, 22 Jan 2020 21:13:13 +0000 (UTC) (envelope-from melifaro@ipfw.ru) Received: from mxback9q.mail.yandex.net (mxback9q.mail.yandex.net [IPv6:2a02:6b8:c0e:6b:0:640:b813:52e4]) by forward500p.mail.yandex.net (Yandex) with ESMTP id 92F2994010D; Thu, 23 Jan 2020 00:13:09 +0300 (MSK) Received: from localhost (localhost [::1]) by mxback9q.mail.yandex.net (mxback/Yandex) with ESMTP id OcpHRvF7Dr-D9wubrNJ; Thu, 23 Jan 2020 00:13:09 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ipfw.ru; s=mail; t=1579727589; bh=KJSyahvpQltWhE3gzNe5Fam/aS4D050O25K+2nlNB+4=; h=Message-Id:Subject:In-Reply-To:Date:References:To:From; b=TicGOxNWJEtZDE9KP5T4/qQJebXNjTKG5eUdMGbezLqM9YjTiZ8I64OjAfO9iiBe7 WCJZ5dHhKy/H3yfxAhjzt0NwRYYqIVwohlj0fPoq157NmYbIy1j/Gfm3G4DYp0OPvU 9GEtNOsZHVygfdzVUwJ1XdP+Tpv0guQVRmXQV8+g= Received: by vla5-4a37cde0b550.qloud-c.yandex.net with HTTP; Thu, 23 Jan 2020 00:13:09 +0300 From: Alexander V. Chernikov Envelope-From: melifaro@ipfw.ru To: Alexander Motin , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" In-Reply-To: <9b379fd1-3774-601d-1ea2-96003e0850cd@FreeBSD.org> References: <202001222036.00MKakdv056453@repo.freebsd.org> <186041579726759@vla5-4452c58d5c14.qloud-c.yandex.net> <9b379fd1-3774-601d-1ea2-96003e0850cd@FreeBSD.org> Subject: Re: svn commit: r356993 - head/sys/net MIME-Version: 1.0 X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Wed, 22 Jan 2020 21:13:09 +0000 Message-Id: <219901579727589@vla5-4a37cde0b550.qloud-c.yandex.net> Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=utf-8 X-Rspamd-Queue-Id: 482ymp03QCz4Y6n X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Jan 2020 21:13:14 -0000 22.01.2020, 21:02, "Alexander Motin" : > On 22.01.2020 15:59, Alexander V. Chernikov wrote: >>  22.01.2020, 20:36, "Alexander Motin" : >>>  Author: mav >>>  Date: Wed Jan 22 20:36:45 2020 >>>  New Revision: 356993 >>>  URL: https://svnweb.freebsd.org/changeset/base/356993 >>> >>>  Log: >>>    Update route MTUs for bridge, lagg and vlan interfaces. >>> >>>    Those interfaces may implicitly change their MTU on addition of parent >>>    interface in addition to normal SIOCSIFMTU ioctl path, where the route >>>    MTUs are updated normally. >>> >>>    MFC after: 2 weeks >>>    Sponsored by: iXsystems, Inc. >>> >>>  Modified: >>>    head/sys/net/if_bridge.c >>>    head/sys/net/if_lagg.c >>>    head/sys/net/if_vlan.c >>  I'd suggest not duplicating business logic on providing notifications to multiple subsystems in each driver. This adds unnecessary complexity/layer violations. What do you think of creating something like if_notify_mtu_change(), embed these 2 calls there and use it everywhere? > > I'd be happy to use such KPI, but would prefer somebody more familiar > with modern ifnet tendencies then me to design it. ;) I guess raising a review with addition of such a KPI would summon some folks if they're not happy :-) The current change looks rather hackish and I'd really love to see a bit more accurate version in a tree.. > > -- > Alexander Motin