Date: Wed, 22 Jan 2020 21:13:09 +0000 From: Alexander V. Chernikov <melifaro@freebsd.org> To: Alexander Motin <mav@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r356993 - head/sys/net Message-ID: <219901579727589@vla5-4a37cde0b550.qloud-c.yandex.net> In-Reply-To: <9b379fd1-3774-601d-1ea2-96003e0850cd@FreeBSD.org> References: <202001222036.00MKakdv056453@repo.freebsd.org> <186041579726759@vla5-4452c58d5c14.qloud-c.yandex.net> <9b379fd1-3774-601d-1ea2-96003e0850cd@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
22.01.2020, 21:02, "Alexander Motin" <mav@freebsd.org>: > On 22.01.2020 15:59, Alexander V. Chernikov wrote: >> 22.01.2020, 20:36, "Alexander Motin" <mav@freebsd.org>: >>> Author: mav >>> Date: Wed Jan 22 20:36:45 2020 >>> New Revision: 356993 >>> URL: https://svnweb.freebsd.org/changeset/base/356993 >>> >>> Log: >>> Update route MTUs for bridge, lagg and vlan interfaces. >>> >>> Those interfaces may implicitly change their MTU on addition of parent >>> interface in addition to normal SIOCSIFMTU ioctl path, where the route >>> MTUs are updated normally. >>> >>> MFC after: 2 weeks >>> Sponsored by: iXsystems, Inc. >>> >>> Modified: >>> head/sys/net/if_bridge.c >>> head/sys/net/if_lagg.c >>> head/sys/net/if_vlan.c >> I'd suggest not duplicating business logic on providing notifications to multiple subsystems in each driver. This adds unnecessary complexity/layer violations. What do you think of creating something like if_notify_mtu_change(), embed these 2 calls there and use it everywhere? > > I'd be happy to use such KPI, but would prefer somebody more familiar > with modern ifnet tendencies then me to design it. ;) I guess raising a review with addition of such a KPI would summon some folks if they're not happy :-) The current change looks rather hackish and I'd really love to see a bit more accurate version in a tree.. > > -- > Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?219901579727589>