From owner-freebsd-stable@FreeBSD.ORG Tue Jul 19 18:17:05 2011 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB04F106566B for ; Tue, 19 Jul 2011 18:17:04 +0000 (UTC) (envelope-from artemb@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 7228B8FC12 for ; Tue, 19 Jul 2011 18:17:04 +0000 (UTC) Received: by wwe6 with SMTP id 6so4234774wwe.31 for ; Tue, 19 Jul 2011 11:17:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ZdzqH6Fa73SE3Q4vp3qFCFYbUmPj485RyX5NS4/yHQY=; b=OvhE9xur+rGnH72e6xuz6DQQQn0rQ14NJfysj0lehACywq83j1ivxBaQAnCctg7YxF u/kNKNog6EZc2HWx642rS18Q/iz6hAuNZVeKAzMdCySiolBUadCCshEP3Af1181I0d4E xLiexSEAWEL3CilycfvP4N5P1/kYFOICICVgc= MIME-Version: 1.0 Received: by 10.217.4.66 with SMTP id t44mr4402444wes.25.1311099422507; Tue, 19 Jul 2011 11:17:02 -0700 (PDT) Sender: artemb@gmail.com Received: by 10.216.46.18 with HTTP; Tue, 19 Jul 2011 11:17:02 -0700 (PDT) In-Reply-To: <201107190931.36492.jhb@freebsd.org> References: <4E20BA23.13717.66C6F57@markmcconnell.iinet.com> <201107181714.07827.jhb@freebsd.org> <4F739848-E3CE-4E2C-A91E-90F33410E7AC@samsco.org> <201107190931.36492.jhb@freebsd.org> Date: Tue, 19 Jul 2011 11:17:02 -0700 X-Google-Sender-Auth: -zE2sQ3PjxGXeXiQrtsxHhRHXV8 Message-ID: From: Artem Belevich To: John Baldwin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: markmc@dataabstractsolutions.com, "freebsd-stable@freebsd.org Stable" Subject: Re: disable 64-bit dma for one PCI slot only? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2011 18:17:05 -0000 On Tue, Jul 19, 2011 at 6:31 AM, John Baldwin wrote: > The only reason it might be nice to stick with two fields is due to the l= ine > length (though the first line is over 80 cols even in the current format)= . =A0Here > are two possible suggestions: > > old: > > hostb0@pci0:0:0:0: =A0 =A0 =A0class=3D0x060000 card=3D0x20108086 chip=3D0= x01008086 rev=3D0x09 hdr=3D0x00 > pcib1@pci0:0:1:0: =A0 =A0 =A0 class=3D0x060400 card=3D0x20108086 chip=3D0= x01018086 rev=3D0x09 hdr=3D0x01 > pcib2@pci0:0:1:1: =A0 =A0 =A0 class=3D0x060400 card=3D0x20108086 chip=3D0= x01058086 rev=3D0x09 hdr=3D0x01 > none0@pci0:0:22:0: =A0 =A0 =A0class=3D0x078000 card=3D0x47428086 chip=3D0= x1c3a8086 rev=3D0x04 hdr=3D0x00 > em0@pci0:0:25:0: =A0 =A0 =A0 =A0class=3D0x020000 card=3D0x00008086 chip= =3D0x15038086 rev=3D0x04 hdr=3D0x00 > ... > > A) > > hostb0@pci0:0:0:0: =A0 =A0 =A0class=3D0x060000 vendor=3D0x8086 device=3D0= x0100 subvendor=3D0x8086 subdevice=3D0x2010 rev=3D0x09 hdr=3D0x00 > pcib1@pci0:0:1:0: =A0 =A0 =A0 class=3D0x060400 vendor=3D0x8086 device=3D0= x0101 subvendor=3D0x8086 subdevice=3D0x2010 rev=3D0x09 hdr=3D0x01 > pcib2@pci0:0:1:1: =A0 =A0 =A0 class=3D0x060400 vendor=3D0x8086 device=3D0= x0105 subvendor=3D0x8086 subdevice=3D0x2010 rev=3D0x09 hdr=3D0x01 > none0@pci0:0:22:0: =A0 =A0 =A0class=3D0x078000 vendor=3D0x8086 device=3D0= x1c3a subvendor=3D0x8086 subdevice=3D0x4742 rev=3D0x04 hdr=3D0x00 > em0@pci0:0:25:0: =A0 =A0 =A0 =A0class=3D0x020000 vendor=3D0x8086 device= =3D0x1503 subvendor=3D0x8086 subdevice=3D0x0000 rev=3D0x04 hdr=3D0x00 > ... > > B) > > hostb0@pci0:0:0:0: =A0 =A0 =A0class=3D0x060000 devid=3D0x8086:0100 subid= =3D0x8086:2010 rev=3D0x09 hdr=3D0x00 > pcib1@pci0:0:1:0: =A0 =A0 =A0 class=3D0x060400 devid=3D0x8086:0101 subid= =3D0x8086:2010 rev=3D0x09 hdr=3D0x01 > pcib2@pci0:0:1:1: =A0 =A0 =A0 class=3D0x060400 devid=3D0x8086:0105 subid= =3D0x8086:2010 rev=3D0x09 hdr=3D0x01 > none0@pci0:0:22:0: =A0 =A0 =A0class=3D0x078000 devid=3D0x8086:1c3a subid= =3D0x8086:4742 rev=3D0x04 hdr=3D0x00 > em0@pci0:0:25:0: =A0 =A0 =A0 =A0class=3D0x020000 devid=3D0x8086:1503 subi= d=3D0x8086:0000 rev=3D0x04 hdr=3D0x00 > ... > > I went with vendor word first for both A) and B) as in my experience that= is > the more common ordering in driver tables, etc. Do we need to print (class|devid|device|subvendor|etc.)=3D on every line? IMHO they belong to a header line. Something like this: Driver Handle Class Vnd:Dev Sub Vnd:Dev Rev Hdr ------------------------------------------------------------------ hostb0 pci0:0:0:0 0x060000 0x8086:0100 0x8086:2010 0x09 0x00 pcib1 pci0:0:1:0 0x060400 0x8086:0101 0x8086:2010 0x09 0x01 pcib2 pci0:0:1:1 0x060400 0x8086:0105 0x8086:2010 0x09 0x01 none0 pci0:0:22:0 0x078000 0x8086:1c3a 0x8086:4742 0x04 0x00 em0 pci0:0:25:0 0x020000 0x8086:1503 0x8086:0000 0x04 0x00 --Artem