From owner-freebsd-current@FreeBSD.ORG Wed Jun 2 18:02:33 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E85E716A4CE for ; Wed, 2 Jun 2004 18:02:33 -0700 (PDT) Received: from mail-in-04.arcor-online.net (mail-in-04.arcor-online.net [151.189.21.44]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1D79343D45 for ; Wed, 2 Jun 2004 18:02:33 -0700 (PDT) (envelope-from mailnull@mips.inka.de) Received: from kemoauc.mips.inka.de (dsl-082-082-076-184.arcor-ip.net [82.82.76.184]) by mail-in-04.arcor-online.net (Postfix) with ESMTP id 66022C4937F for ; Thu, 3 Jun 2004 03:02:31 +0200 (CEST) Received: from kemoauc.mips.inka.de (localhost [127.0.0.1]) i5312UtP036245 for ; Thu, 3 Jun 2004 03:02:30 +0200 (CEST) (envelope-from mailnull@kemoauc.mips.inka.de) Received: (from mailnull@localhost) by kemoauc.mips.inka.de (8.12.11/8.12.11/Submit) id i5312TH2036244 for freebsd-current@freebsd.org; Thu, 3 Jun 2004 03:02:29 +0200 (CEST) (envelope-from mailnull) From: naddy@mips.inka.de (Christian Weisgerber) Date: Thu, 3 Jun 2004 01:02:27 +0000 (UTC) Message-ID: Originator: naddy@mips.inka.de (Christian Weisgerber) To: freebsd-current@freebsd.org Subject: Network driver jumbo patch (affects multicast) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Jun 2004 01:02:34 -0000 I have just committed two helper functions to our ethernet support infrastructure: uint32_t ether_crc32_le(const uint8_t *, size_t); uint32_t ether_crc32_be(const uint8_t *, size_t); Numerous drivers bring their own implementations of these functions to calculate the standard ethernet CRC in little/big endian fashion, usually used for setting up multicast hash filters. This jumbo patch replaces the local implementations with calls to the helper functions: http://people.freebsd.org/~naddy/ether_crc32.patch The changes are straightforward, almost mechanical, but typos may have snuck in, so PLEASE TEST. This touches a whopping 28 network drivers: aue, axe, bge, cue, dc, de, ed, fe, gem, hme, lge, lnc, my, nge, pcn, re, rl, rue, sf, sis, sk, sn, ste, tx, udav, vr, wb, xl Breakage would usually show up as multicast reception not working. Apart from outright multicast applications this also affects some routing protocols and all IPv6 users (since NDP uses multicast). Don't report success if you don't understand what I'm talking about. -- Christian "naddy" Weisgerber naddy@mips.inka.de