From owner-freebsd-ports@freebsd.org Wed Aug 29 07:46:42 2018 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E79E210804CE for ; Wed, 29 Aug 2018 07:46:41 +0000 (UTC) (envelope-from peo@nethead.se) Received: from ns1.nethead.se (ns1.nethead.se [5.150.237.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "ns1.nethead.se", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7671180C04; Wed, 29 Aug 2018 07:46:41 +0000 (UTC) (envelope-from peo@nethead.se) X-Virus-Scanned: amavisd-new at Nethead AB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nethead.se; s=NETHEADSE; t=1535528792; bh=djenHE7xmhwlubr8ti/fniGjqBVABn3YiAmC2WJTknE=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=UYeY/io+t39OrAwkhxXEcX03yq5S2aJmYfBkfjASb1qY7wuTr9P/hb1HlOMd1PNJc Q4g9M2o4CTxjB81gZ7EciAfb2Q9xfAOhI/KsD7ifixH1Hcfrf8Hq7weBKpbZJ01qp1 qhaBQxaEwbr4G1NexRVFurJIdNkq2UGo3GrvN0qI= Subject: Re: Cannot specify ntpd binary in ports with ntpd startup file. To: "Dan Mahoney (Gushi)" , freebsd-ports@freebsd.org Cc: cy@freebsd.org References: From: Per olof Ljungmark Message-ID: <48ae339f-df32-371f-f51f-55c4531848bf@nethead.se> Date: Wed, 29 Aug 2018 09:46:24 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 07:46:42 -0000 Hi, On 8/29/18 2:34 AM, Dan Mahoney (Gushi) wrote: > 1) Got the version wrong.  I'm on 10.4. > > 2) Forgot a subject.  Whoops. > > 3) Forgot to cc maintainer.  Doh! > > -Dan > > On Tue, 28 Aug 2018, Dan Mahoney (Gushi) wrote: > >> Hey all, >> >> Funny question.  I'm on FreeBSD 11.4, and would like to use the latest >> version of NTP, which is in pkg. >> >> The version in pkg doesn't have a startup script, which I'm not sure >> is supposed to be the case.  I know for things like BIND (when it was >> both in base and in ports) you could override the binary in /etc/rc.conf. >> >> However, the version of /etc/rc.d/ntpd in BASE doesn't seem to have >> the ability to override the binary in rc.conf: >> >> name="ntpd" >> rcvar="ntpd_enable" >> command="/usr/sbin/${name}" >> pidfile="/var/run/${name}.pid" >> extra_commands="fetch" >> fetch_cmd="ntpd_fetch_leapfile" >> start_precmd="ntpd_precmd" >> >> What's weirder, is even if I manually modify the /etc/rc.d/ntpd file >> to point at /usr/local/sbin (which I should never have to do), the >> version in /usr/sbin gets started. >> >> root@vortex2:/etc/rc.d # service ntpd start >> Starting ntpd. >> root@vortex2:/etc/rc.d # ps auxwww|grep ntpd >> root     36362  38.3  0.2 26192 18132  -  Ss   12:17AM    0:04.73 >> /usr/sbin/ntpd -c /etc/ntp.conf -p /var/run/ntpd.pid -f >> /var/db/ntpd.drift >> root     36364   0.0  0.0 18844  2328  1  R+   12:17AM    0:00.00 grep >> ntpd >> root@vortex2:/etc/rc.d # grep command ntpd >> command="/usr/local/sbin/${name}" >> [...] >> >> So, asking as a port maintainer, a few questions: >> >> 0) Why the heck is it doing this even when I override the path? >> >> 1) How can we encourage base to allow override of command_name? >> >> 2) Is this a brokenness in the port that it doesn't ship with a >> startup file? >> >> 3) Not strictly related, but what's the proper case for pathing since >> things like "ntpq", the base path would naturally be found in any >> standard $PATH. Some ports used to have an overwrite_base option, but >> this also feels wrong as it breaks freebsd-update in various ways.  >> I.e. should the port print a message stating that you should chmod 000 >> the original binaries?  Should the ports versions be named something >> different?  Should the port just warn you that you need to call these >> things by absolute path, always? >> I think you should post your /etc/rc.conf There are lots of defaults in 11-STABLE which I run: grep ntp defaults/rc.conf ntpdate_enable="NO" # Run ntpdate to sync time on boot (or NO). ntpdate_program="/usr/sbin/ntpdate" # path to ntpdate, if you want a different one. ntpdate_flags="-b" # Flags to ntpdate (if enabled). ntpdate_config="/etc/ntp.conf" # ntpdate(8) configuration file ntpdate_hosts="" # Whitespace-separated list of ntpdate(8) servers. ntpd_enable="NO" # Run ntpd Network Time Protocol (or NO). ntpd_program="/usr/sbin/ntpd" # path to ntpd, if you want a different one. ntpd_config="/etc/ntp.conf" # ntpd(8) configuration file ntpd_sync_on_start="NO" # Sync time on ntpd startup, even if offset is high ntpd_flags="-p /var/run/ntpd.pid -f /var/db/ntpd.drift" # Flags to ntpd (if enabled). ntp_src_leapfile="/etc/ntp/leap-seconds" # Initial source for ntpd leapfile ntp_db_leapfile="/var/db/ntpd.leap-seconds.list" ntp_leapfile_sources="https://www.ietf.org/timezones/data/leap-seconds.list" ntp_leapfile_fetch_opts="-mq" # Options to use for ntp leapfile fetch, ntp_leapfile_expiry_days=30 # Check for new leapfile 30 days prior to ntp_leapfile_fetch_verbose="NO" # Be verbose during NTP leapfile fetch