From owner-svn-src-all@freebsd.org Wed Mar 16 14:02:03 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A3CBAD315D; Wed, 16 Mar 2016 14:02:03 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 101F7A4B; Wed, 16 Mar 2016 14:02:03 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wm0-x231.google.com with SMTP id l68so74014788wml.1; Wed, 16 Mar 2016 07:02:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=vZ0qmqyuNbqy5ZiFExmJAXiND1eS3/5O4/aC8ZPNbTc=; b=itmZf1dcv4bIryiJyon28DzwjIwHrkWYcNdiJNxqWCRpgVUasDuTMQfP/qQw7qJSeV 5aO+NsegtucZfORowXPPLmoD7M1OWIXQsDc8Z1X+U1Nww6dynuCoXWMilYFzvVYxELFa fRF4MBR2cwtKuFzR0X7x4E3qDWnP9FJx423hIKyxo2AHblDOdBjGyPlU6m6DSS651nS5 oJj4MevFVwhHNUT6wREHzMyGfLiW9Nbtp3VcQe3lEHDX7+lGTCxmtgGTZT+Oj5odLUG8 IqjFzlIpdkJN209DnUNEdxf/h1pZJ66XRmynMqfcYD97btBIN5AjrazVDgQDL1OmannU bTRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=vZ0qmqyuNbqy5ZiFExmJAXiND1eS3/5O4/aC8ZPNbTc=; b=AtjB93MJz/reTNlllXcmEDpAxEckvpsQf/WwbJD7lu9BPrQjUKHBPTUXRw0dCQvFOb XlfimRlwnkLfrAB1ZOB+KHX++D6kcVjIVwWTy2F6RieJlleL26l2FbR7BWj8RpN4jahf 77mLxomowx5vPvmbdHaOYXCmVAgWvSPicgIpdaa4GgTwa1SXvdv02FLaA1wKSiSFUlPA 6puewWp4z1d5+JVNL5RoBG96yr2Xxq/hEbEUHQDo30vKfBpwxXCYfjqPIzIMLLcqHUUf nv9u+Qu/6HlVd5qX8vGf7yNm+ZjFKfp5/eJzr9lEmg3hkOsfFrBUy1OgrktXFp/dxgQX eM3w== X-Gm-Message-State: AD7BkJKCT9gJzUf6+lWqWLQWwdY7K4hXnCsBvgITg41OAptW/xS4x66iKxhCuBxwLA7VKQ== X-Received: by 10.194.87.161 with SMTP id az1mr4022167wjb.163.1458136921604; Wed, 16 Mar 2016 07:02:01 -0700 (PDT) Received: from brick.home (etb152.neoplus.adsl.tpnet.pl. [83.20.147.152]) by smtp.gmail.com with ESMTPSA id u16sm3696516wmd.5.2016.03.16.07.01.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Mar 2016 07:01:59 -0700 (PDT) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Wed, 16 Mar 2016 15:01:56 +0100 From: Edward Tomasz Napierala To: Conrad Meyer Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r296918 - head/sys/fs/autofs Message-ID: <20160316140156.GA3846@brick.home> Mail-Followup-To: Conrad Meyer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201603152042.u2FKgafc073412@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Mar 2016 14:02:03 -0000 You're right. I've added the explicit cast to void, let's see if that helps. On 0315T1346, Conrad Meyer wrote: > Instead you will get, "warning: unused but set variable 'error'" on > -NODEBUG builds. Maybe add: > > (void)error; > > Best, > Conrad > > On Tue, Mar 15, 2016 at 1:42 PM, Edward Tomasz Napierala > wrote: > > Author: trasz > > Date: Tue Mar 15 20:42:36 2016 > > New Revision: 296918 > > URL: https://svnweb.freebsd.org/changeset/base/296918 > > > > Log: > > Pacify Coverity. > > > > MFC after: 1 month > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > head/sys/fs/autofs/autofs_vnops.c > > > > Modified: head/sys/fs/autofs/autofs_vnops.c > > ============================================================================== > > --- head/sys/fs/autofs/autofs_vnops.c Tue Mar 15 19:45:24 2016 (r296917) > > +++ head/sys/fs/autofs/autofs_vnops.c Tue Mar 15 20:42:36 2016 (r296918) > > @@ -370,8 +370,10 @@ static size_t > > autofs_dirent_reclen(const char *name) > > { > > size_t reclen; > > + int error; > > > > - autofs_readdir_one(NULL, name, -1, &reclen); > > + error = autofs_readdir_one(NULL, name, -1, &reclen); > > + KASSERT(error == 0, ("autofs_readdir_one() failed")); > > > > return (reclen); > > } > >