From owner-freebsd-cvsweb@FreeBSD.ORG Tue Apr 5 20:41:59 2005 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C3BF416A4CE for ; Tue, 5 Apr 2005 20:41:59 +0000 (GMT) Received: from smtp818.mail.sc5.yahoo.com (smtp818.mail.sc5.yahoo.com [66.163.170.4]) by mx1.FreeBSD.org (Postfix) with SMTP id 8043743D48 for ; Tue, 5 Apr 2005 20:41:59 +0000 (GMT) (envelope-from noackjr@alumni.rice.edu) Received: from unknown (HELO optimator.noacks.org) (noacks@swbell.net@70.240.251.38 with login) by smtp818.mail.sc5.yahoo.com with SMTP; 5 Apr 2005 20:41:38 -0000 Received: from localhost (localhost [127.0.0.1]) by optimator.noacks.org (Postfix) with ESMTP id 9D89461D0; Tue, 5 Apr 2005 15:41:37 -0500 (CDT) Received: from optimator.noacks.org ([127.0.0.1]) by localhost (optimator.noacks.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 08875-04; Tue, 5 Apr 2005 15:41:34 -0500 (CDT) Received: from [127.0.0.1] (optimator [192.168.1.11]) by optimator.noacks.org (Postfix) with ESMTP id BBA1F612C; Tue, 5 Apr 2005 15:41:34 -0500 (CDT) Message-ID: <4252F7FE.1050507@alumni.rice.edu> Date: Tue, 05 Apr 2005 15:41:34 -0500 From: Jon Noack User-Agent: Mozilla Thunderbird 1.0.2 (Windows/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Klas Eriksson References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: amavisd-new at noacks.org cc: freebsd-cvsweb@freebsd.org Subject: Re: [BUG] download link doesn't work if path has spaces. X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: noackjr@alumni.rice.edu List-Id: CVS Web maintenance mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Apr 2005 20:41:59 -0000 On 3/14/2005 10:00 AM, Klas Eriksson wrote: > Ville Skyttä wrote: >>On Wed, 2004-10-13 at 23:12, Russell Francis wrote: >>>I am using CVSweb 3.0.1 and discovered that if any file contained in a >>>CVS module has a space character in it's path, the download link will >>>fail to download the file. >> >>Known issue, fixed in the current version of CVSweb, 3.0.2.scape($revision); > > Still a bug in 3.0.5, but on the "CVS log" page . > Click 'download', then space is encoded as "+", not "%20". Klas, I am unable to recreate this issue. Every download link I can find encodes spaces as "%20". In my testing I created files with spaces inside of directories with spaces and had no problems. Can you provide a link that shows the issue or a more detailed procedure for how to recreate it? Note that CVSweb uses URI::Escape to do the actual encoding. You might want to check that you have the most recent version (URI 1.35 includes URI::Escape 3.28; these are the versions I am using): http://search.cpan.org/dist/URI/ http://www.freshports.org/net/p5-URI/ Regards, Jon