From owner-freebsd-current@FreeBSD.ORG  Fri Jul 31 23:37:17 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EE7811065673;
	Fri, 31 Jul 2009 23:37:17 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211])
	by mx1.freebsd.org (Postfix) with ESMTP id 8F9F98FC16;
	Fri, 31 Jul 2009 23:37:17 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 5C72E1CF05; Sat,  1 Aug 2009 01:37:16 +0200 (CEST)
Date: Sat, 1 Aug 2009 01:37:16 +0200
From: Ed Schouten <ed@80386.nl>
To: Hans Petter Selasky <hselasky@c2i.net>
Message-ID: <20090731233716.GT1292@hoeg.nl>
References: <3bbf2fe10907310759o3be1f565t4122fcd66c4531f4@mail.gmail.com>
	<200907311818.08481.hselasky@c2i.net>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="QHp3Wr1K3N9pKO2V"
Content-Disposition: inline
In-Reply-To: <200907311818.08481.hselasky@c2i.net>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Attilio Rao <attilio@freebsd.org>, Peter Holm <pho@freebsd.org>,
	freebsd-current@freebsd.org
Subject: Re: [PATCH] Newbus locking
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Jul 2009 23:37:18 -0000


--QHp3Wr1K3N9pKO2V
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Hans Petter Selasky <hselasky@c2i.net> wrote:
> I was hoping that the Giant requirement for newbus would go away, but all=
 that=20
> has been done is to replace Giant with an sx-lock protecting all access a=
nd=20
> calls into any device_xxx() method. This is a step backwards.

Gradually decomposing Giant should always be considered a step forward.
For example, I am sure people will have dozens of comments on how I
could have improved locking inside the TTY layer, but it's still better
than what we had.

<nitpick>
Attilio, I'm too stupid to understand Newbus, but I spotted a small typo
in acpi_battery.c: Tollerate -> Tolerate. There's also a small
whitespace regression in the first chunk of the same file.
</nitpick>

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--QHp3Wr1K3N9pKO2V
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkpzgCwACgkQ52SDGA2eCwXhFQCfQrQZvCwLZj0rD+ZqsRB2cfn7
8/kAn1aZJMiCZkzympu3qApCNuf4koH7
=Whsf
-----END PGP SIGNATURE-----

--QHp3Wr1K3N9pKO2V--