From nobody Thu Jun 4 12:57:50 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gWPk804Kqz6gDJ7; Thu, 04 Jun 2026 12:57:52 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gWPk76X0kz3Vkj; Thu, 04 Jun 2026 12:57:51 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780577871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZT1x1wPIIQd6XZpwNvicqvFeFKvY0u8X0R4x22IfaO8=; b=syyXm/khGEM5qtHBOapIIhpRoXEp+5qOr+D9LFgJ2u3fxpPWiRVB/mRgY3mh6PnxNpRx5w tBeOi2tp0r0nRZlTZBXbLtypLIfbuh5r1JQeOJtG3pZ4ftA4r+DikJuDQnZzTs/bWKamut 07xQseiicSXGSWTUqlawbMeLExDQqBIuhRzotjykkPGiZfKOonMzmTuOeDBoDw4yW9aUm2 nX9/KZa6GDgpZtrOXxhpb4BTHTIlfdAqpyenYqyQj8i7enpkqgGBqRMrhoMwnGPBSIqqr9 pb0PUL6XmAlUWmie+Zh0nxdjcyRprKxx+JkKxM7b7mUUB0zilxpnJOsYr3kk1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780577871; a=rsa-sha256; cv=none; b=g0Zvi8+f8a4FcG5DO+k16Doir9HjQYNkeJM79DeVeDoTQjUOttUpybaKIlKVXh/Olq/Buf t82ga+A0z/RbZvavoEUBLM88MQaKsbnvLZql8Hy9wbjKnqFPjDnVT3uZEJOfSojiWiNTTo /9hxXnSPS3WVv1FU2YB8uodTIblBhZLcP3XftzIvYRFTk78gkxuO/8iz55E5OuRthBZjI6 PDkwrL1Q+23m9s9RhhBPfBYWx9k8VIs/NKKPsXea84JbIzGdTuh2BTAWnrPkqlxorbYwpO pCYRIRDPMjPQI5NevAixbkaZRnRzLOQonnfmZRqGafIEMKP1Y0rvtwkJLsDhbg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780577871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZT1x1wPIIQd6XZpwNvicqvFeFKvY0u8X0R4x22IfaO8=; b=nwgWf/SWjNjCOEFYg3PMeGi47EWR2327J2s2sKmikfS+PZy1/Bq4WCzHcFfJUIdPe7uzAy WM7fLIkg09FNIXrDg8Ih1PB08BC8bW+CFJzD+MRa8aJ3s8h+lJOryprGlI9o9wCn2C4Zit IXu+vScu+R6TQjWpwA48hkr/WgyTDD7SU6mDFKlg9QkzyoJn7t9BhT4BPunRXBZnhUDA/a p6yZ9SvjYzOglSZzwzEQm4WNqf6Mi2VhmVjgBohOifWCtjLbq5LerIFzCznJwAeQ5U6dri LuZygZBJLIBi6VU9Cq9fDWlcTxaAIuZkowkhCp+3jKA9Eew21mbnxTPM7aFiBQ== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gWPk75cDZz13Tf; Thu, 04 Jun 2026 12:57:51 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 10EAF3C01A0; Thu, 04 Jun 2026 12:57:51 +0000 (UTC) Date: Thu, 4 Jun 2026 12:57:50 +0000 From: Brooks Davis To: Olivier Certner Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7487932f4fbc - main - assert.h: style(9): Space after #define, between #endif and comment Message-ID: References: <6a2166aa.22490.59890f0d@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a2166aa.22490.59890f0d@gitrepo.freebsd.org> On Thu, Jun 04, 2026 at 11:51:06AM +0000, Olivier Certner wrote: > The branch main has been updated by olce: > > URL: https://cgit.FreeBSD.org/src/commit/?id=7487932f4fbc5a71231d3b1fc93d160253f38c83 > > commit 7487932f4fbc5a71231d3b1fc93d160253f38c83 > Author: Olivier Certner > AuthorDate: 2026-06-02 10:01:05 +0000 > Commit: Olivier Certner > CommitDate: 2026-06-04 11:49:26 +0000 > > assert.h: style(9): Space after #define, between #endif and comment > > style(9) still allows TAB after #define but this is a historical > artifact and by far the minority of uses cases. Going forward, we would > like to promote the use of a single space, as it allows alignment to > survive line prefixing (such as in diffs). > > style(9) also has prescribed a single space between '#else' or '#endif' > and a comment recalling the guard since 2002. > > So, commit 157c184689ea ("assert.h: Remove leading tabs for whitespace > consistency") was good, and in line with rules about whitespace changes > (since the file was heavily modified by surrounding commits). > > This commit is thus basically a revert of 439710cf003b ("assert.h: > Revert "Remove leading tabs for whitespace consistency"), which extended > replacing spaces with TABs in the code introduced in the meantime (after > commit 157c184689ea). Please add all three commits to .git-blame-ignore-revs. -- Brooks