From owner-svn-src-head@FreeBSD.ORG Thu Jun 18 03:07:21 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 49191C0E; Thu, 18 Jun 2015 03:07:21 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B209CF94; Thu, 18 Jun 2015 03:07:20 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id t5I37FKO003852 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 18 Jun 2015 06:07:15 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t5I37FKO003852 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id t5I37FKW003851; Thu, 18 Jun 2015 06:07:15 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 18 Jun 2015 06:07:15 +0300 From: Konstantin Belousov To: Sean Bruno Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284535 - head/sys/kern Message-ID: <20150618030715.GD2080@kib.kiev.ua> References: <201506180204.t5I24LJm079537@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201506180204.t5I24LJm079537@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Jun 2015 03:07:21 -0000 On Thu, Jun 18, 2015 at 02:04:21AM +0000, Sean Bruno wrote: > Author: sbruno > Date: Thu Jun 18 02:04:20 2015 > New Revision: 284535 > URL: https://svnweb.freebsd.org/changeset/base/284535 > > Log: > This change replaces the mutex with a sx lock for the interpreter list to > avoid the problem of holding a non-sleep lock during a page fault as > reported by witness. It also uses atomics where possible to avoid having > to acquire the exclusive lock. In addition, it consistently uses > memset()/memcpy() instead of bzero()/bcopy(). > > Differential Revision: https://reviews.freebsd.org/D1971 > Submitted by: sson > Reviewed by: jhb What are the page faults during image activator run ? Or, if the page faults are not during image activation, then where ? > > @@ -404,12 +404,12 @@ imgact_binmisc_get_all_entries(struct sy > imgact_binmisc_entry_t *ibe; > int error = 0, count; > > - mtx_lock(&interp_list_mtx); > + sx_slock(&interp_list_sx); > count = interp_list_entry_count; > /* Don't block in malloc() while holding lock. */ > xbe = malloc(sizeof(*xbe) * count, M_BINMISC, M_NOWAIT|M_ZERO); This is definitely no longer true statement. Even the original use of M_NOWAIT there is not warranted. > if (!xbe) { > - mtx_unlock(&interp_list_mtx); > + sx_sunlock(&interp_list_sx); > return (ENOMEM); > } >