From owner-svn-src-all@freebsd.org Tue Jan 17 23:52:37 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 231CDCB56FC for ; Tue, 17 Jan 2017 23:52:37 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AAE4A1FF1 for ; Tue, 17 Jan 2017 23:52:35 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 04a44090-dd10-11e6-9357-bffcd86bd944 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 04a44090-dd10-11e6-9357-bffcd86bd944; Tue, 17 Jan 2017 23:52:36 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v0HNqPxi018516; Tue, 17 Jan 2017 16:52:25 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1484697145.86335.183.camel@freebsd.org> Subject: Re: svn commit: r312296 - in head: lib/libc/sys sys/kern sys/netinet sys/netinet6 sys/sys tools/regression/sockets/udp_pingpong tools/regression/sockets/unix_cmsg From: Ian Lepore To: cem@freebsd.org, Maxim Sobolev Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 17 Jan 2017 16:52:25 -0700 In-Reply-To: References: <201701161746.v0GHkcPX071529@repo.freebsd.org> <20170117065231.GW2611@FreeBSD.org> <20170117212713.GZ2611@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 23:52:37 -0000 I actually don't agree that it's all good, but I also don't have the time to prove it's not (or prove myself wrong, which could certainly be the case). -- Ian On Tue, 2017-01-17 at 15:21 -0800, Conrad Meyer wrote: > Ian's potential objection has been met by Ben Kaduk and Eric van > Gyzen's responses.  It seems like an enum is just fine.  And I agree > with Gleb that it is preferable. > > Conrad > > On Tue, Jan 17, 2017 at 1:34 PM, Maxim Sobolev > wrote: > > > > Well as other pointed out there are some concerns with using enums > > from C++ > > and ABI prospective. So it looks to me that there is no general > > consensus on > > that direction. > > > > -Max > > > > On Tue, Jan 17, 2017 at 1:27 PM, Gleb Smirnoff > > wrote: > > > > > > > > > On Tue, Jan 17, 2017 at 08:40:50AM -0800, Maxim Sobolev wrote: > > > M> That being said, is there any other socket option value in > > > there > > > M> implemented as enum? I don't see anything obvious, so that I > > > am curious > > > if > > > M> it would stick out as an odd one in there. What do you think? > > > > > > Simply because 30 years ago the language didn't allow that, and > > > later > > > additions mimiced the older sockopts. We need to break this loop > > > :) > > > > > > -- > > > Totus tuus, Glebius. > > >