From owner-freebsd-bugs@FreeBSD.ORG Thu Mar 29 20:57:33 2012 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 917501065674; Thu, 29 Mar 2012 20:57:33 +0000 (UTC) (envelope-from jamesbrandongooch@gmail.com) Received: from mail-gx0-f182.google.com (mail-gx0-f182.google.com [209.85.161.182]) by mx1.freebsd.org (Postfix) with ESMTP id D7F3B8FC14; Thu, 29 Mar 2012 20:57:32 +0000 (UTC) Received: by ggnk4 with SMTP id k4so2240701ggn.13 for ; Thu, 29 Mar 2012 13:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=Df1ZARH9gPgmBMNJAChGYN1a5aGqYfInJXkDIbv8/dE=; b=WfW6iImKC0bdKE5+gl9kjK/G9NTJio7hWD/AFpC0Qz9fxRTozTr38IcCl/NrTxz3bc hFKy0pUt3496nHPBYaYGlz+2HdOK8ZtX/SGRPEHdnRmxTEyOVBFAghN28pANW9oUJpLu I6xoSfnM3urJbpT2q4Jf/81BglX2XEzPAvin+HD0eB6nO0viY91ToREyfFTWPMaKuIw2 /5n098gV5hvqJOFtwjcH1iT9et7J1sUeL0tbB1UPfwJ//zrdm05/g0M1RNc2+CWq83Cq z0F9YRBCPKigpjSMklRoK5J8AUTBYEE968RHA6uZwdTMdIS+uJSW9uQ3wRDxY/aJUuZY 9xDQ== MIME-Version: 1.0 Received: by 10.60.13.196 with SMTP id j4mr46093565oec.14.1333054652314; Thu, 29 Mar 2012 13:57:32 -0700 (PDT) Received: by 10.60.17.10 with HTTP; Thu, 29 Mar 2012 13:57:32 -0700 (PDT) In-Reply-To: <4F7410CD.1000200@FreeBSD.org> References: <201203250422.q2P4MsBX047524@freefall.freebsd.org> <4F7410CD.1000200@FreeBSD.org> Date: Thu, 29 Mar 2012 15:57:32 -0500 Message-ID: From: Brandon Gooch To: Alexander Motin Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-bugs@freebsd.org, eadler@freebsd.org Subject: Re: kern/166382: [patch] snd_hda(4) is in a bad state after suspend/resume cycle X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Mar 2012 20:57:33 -0000 On Thu, Mar 29, 2012 at 2:35 AM, Alexander Motin wrote: > On 03/29/12 03:26, Brandon Gooch wrote: >> >> On Sat, Mar 24, 2012 at 11:22 PM, =A0wrote: >>> >>> Synopsis: [patch] snd_hda(4) is in a bad state after suspend/resume cyc= le >>> >>> Responsible-Changed-From-To: freebsd-bugs->mav >>> Responsible-Changed-By: eadler >>> Responsible-Changed-When: Sun Mar 25 04:22:54 UTC 2012 >>> Responsible-Changed-Why: >>> over to maintainer >>> >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D166382 >> >> >> Hey mav, thanks for taking a look and providing a patch! >> Unfortunately, it doesn't fix the suspend/resume issue =A0The headphone >> jack sense polling doesn't work after resume unless the callback is >> reinitialized. >> >> Does it hurt to reinit the callback in the case of both polling and >> non-polling configuartions? > > > Polling is always bad. It is needed only if CODEC can't send unsolicited > responses for jack events. I think I see the real problem: unsolicited > responses are not reconfigured on resume. Please try attached patch. > > -- > Alexander Motin Yes, you're right about polling. And, yes, this is the correct fix, thank = you! -Brandon