Date: Thu, 29 Mar 2012 15:57:32 -0500 From: Brandon Gooch <jamesbrandongooch@gmail.com> To: Alexander Motin <mav@freebsd.org> Cc: freebsd-bugs@freebsd.org, eadler@freebsd.org Subject: Re: kern/166382: [patch] snd_hda(4) is in a bad state after suspend/resume cycle Message-ID: <CALBk6yJ4JxSteyrOxeZ-4WfaN=mZ__dy%2Br4ifo9JCOmT8B7b=A@mail.gmail.com> In-Reply-To: <4F7410CD.1000200@FreeBSD.org> References: <201203250422.q2P4MsBX047524@freefall.freebsd.org> <CALBk6yJ3Zegx-YN3BuOjr-qav-qXW_VSSgOY=sGW4KCBNS3yNA@mail.gmail.com> <4F7410CD.1000200@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Mar 29, 2012 at 2:35 AM, Alexander Motin <mav@freebsd.org> wrote: > On 03/29/12 03:26, Brandon Gooch wrote: >> >> On Sat, Mar 24, 2012 at 11:22 PM,<eadler@freebsd.org> =A0wrote: >>> >>> Synopsis: [patch] snd_hda(4) is in a bad state after suspend/resume cyc= le >>> >>> Responsible-Changed-From-To: freebsd-bugs->mav >>> Responsible-Changed-By: eadler >>> Responsible-Changed-When: Sun Mar 25 04:22:54 UTC 2012 >>> Responsible-Changed-Why: >>> over to maintainer >>> >>> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D166382 >> >> >> Hey mav, thanks for taking a look and providing a patch! >> Unfortunately, it doesn't fix the suspend/resume issue =A0The headphone >> jack sense polling doesn't work after resume unless the callback is >> reinitialized. >> >> Does it hurt to reinit the callback in the case of both polling and >> non-polling configuartions? > > > Polling is always bad. It is needed only if CODEC can't send unsolicited > responses for jack events. I think I see the real problem: unsolicited > responses are not reconfigured on resume. Please try attached patch. > > -- > Alexander Motin Yes, you're right about polling. And, yes, this is the correct fix, thank = you! -Brandon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALBk6yJ4JxSteyrOxeZ-4WfaN=mZ__dy%2Br4ifo9JCOmT8B7b=A>