From owner-cvs-src@FreeBSD.ORG Mon Jun 5 12:32:56 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD78116AA4E; Mon, 5 Jun 2006 12:32:32 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id DBE6F43D53; Mon, 5 Jun 2006 12:32:28 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k55CWHbm050647; Mon, 5 Jun 2006 08:32:18 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Greg 'groggy' Lehey" Date: Mon, 5 Jun 2006 08:30:10 -0400 User-Agent: KMail/1.9.1 References: <200605311315.k4VDFUhD093628@repoman.freebsd.org> <200606020926.14830.jhb@freebsd.org> <20060605001924.GK55506@wantadilla.lemis.com> In-Reply-To: <20060605001924.GK55506@wantadilla.lemis.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200606050830.12584.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 05 Jun 2006 08:32:22 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1512/Sun Jun 4 05:58:49 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Maxim Konovalov , Alexey Dokuchaev , src-committers@freebsd.org, Bruce Evans , cvs-src@freebsd.org, cvs-all@freebsd.org, Ceri Davies Subject: Re: cvs commit: src/sys/ufs/ufs ufs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Jun 2006 12:33:13 -0000 On Sunday 04 June 2006 20:19, Greg 'groggy' Lehey wrote: > On Friday, 2 June 2006 at 9:26:13 -0400, John Baldwin wrote: > > On Friday 02 June 2006 06:25, Greg 'groggy' Lehey wrote: > >> On Friday, 2 June 2006 at 10:38:29 +0100, Ceri Davies wrote: > >>> On Fri, Jun 02, 2006 at 09:54:59AM +0930, Greg 'groggy' Lehey wrote: > >>>> On Friday, 2 June 2006 at 2:50:47 +1000, Bruce Evans wrote: > >>>>> On Thu, 1 Jun 2006, John Baldwin wrote: > >>>>> > >>>>>> On Thursday 01 June 2006 06:01, Alexey Dokuchaev wrote: > >>>>>>> On Thu, Jun 01, 2006 at 10:49:50AM +0100, Ceri Davies wrote: > >>>>>>>> @@ -69,6 +69,10 @@ > >>>>>>>> the file must be open for writing. > >>>>>>>> .Sh RETURN VALUES > >>>>>>>> .Rv -std > >>>>>>>> +If the file to be modified is not a directory or > >>>>>>>> +a regular file, the > >>>>>>>> +.Fn truncate > >>>>>>>> +call will return the value 0. > >>>>>>> > >>>>>>> Doesn't "value of 0" sound better? > >>>>>> > >>>>>> Not to me, though I can't explain why. I think the phrase "X > >>>>>> will return the value Y" is common in man pages though. > >>>>> > >>>>> "will return" sounds strange to be. > >>>> > >>>> Yes, it will be better if you avoid the future tense. > >>> > >>> May I recommend that one of you just change it? > >> > >> What colour? > > > > Shouldn't that be "Which colour?" or even "Which color?" *duck* > > I don't think so. Why should it? Somewhere in my brain there's this notion that if one is choosing amongst a set of items one should use 'which' rather than 'what', e.g. 'which floor' in an elevator rather than 'what floor'. -- John Baldwin