From owner-cvs-src@FreeBSD.ORG  Sun Oct 26 20:22:24 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 9E9F716A4BF; Sun, 26 Oct 2003 20:22:24 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9078843F93; Sun, 26 Oct 2003 20:22:22 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3p2/8.8.7) with ESMTP id PAA08180;
	Mon, 27 Oct 2003 15:21:47 +1100
Date: Mon, 27 Oct 2003 15:21:45 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Hajimu UMEMOTO <ume@mahoroba.org>
In-Reply-To: <ygehe1wi804.wl%ume@mahoroba.org>
Message-ID: <20031027151510.F21211@gamplex.bde.org>
References: <200310251057.h9PAv8pn086818@repoman.freebsd.org>
	<20031025192855.GA96324@rot13.obsecurity.org>
	<20031026040132.GA2036@rot13.obsecurity.org>
	<20031026050059.GA2206@rot13.obsecurity.org>
	<20031026162715.I17272@gamplex.bde.org>
	<ygehe1wi804.wl%ume@mahoroba.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@freebsd.org
cc: Kris Kennaway <kris@obsecurity.org>
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
cc: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Subject: 
	Re: cvs commit: src/sys/netinet icmp6.h ip6.h src/sys/netinet6 in6.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Oct 2003 04:22:24 -0000

On Sun, 26 Oct 2003, Hajimu UMEMOTO wrote:

> >>>>> On Sun, 26 Oct 2003 16:38:38 +1100 (EST)
> >>>>> Bruce Evans <bde@zeta.org.au> said:
>
> bde> - the closure of the changes for <netinet/in.h> apparently included
> bde>   some KAME headers.
>
> I found that there was one use of u_int32_t in newly introduced struct
> definition.  I've just correct to use uint32_t.  I believe it fix the
> problem.  Sorry for the mess.

There are also lots of u_int32_t's in #defines in at least <netinet/in.h>.
These don't prevent including the header without a prior include of
<sys/types.h>, but they prevent using the macros.  There are also some
u_char's in comments.  Many of the macros are not fully parenthesized.
E.g.:

#define	INADDR_ANY		(u_int32_t)0x00000000
#define	IP_MULTICAST_IF		9    /* u_char; set/get IP multicast i/f  */

Bruce