From owner-freebsd-current@FreeBSD.ORG Sat Nov 4 06:59:23 2006 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2686B16A40F; Sat, 4 Nov 2006 06:59:23 +0000 (UTC) (envelope-from jb@what-creek.com) Received: from what-creek.com (what-creek.com [66.111.37.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id B9FFB43D5A; Sat, 4 Nov 2006 06:59:22 +0000 (GMT) (envelope-from jb@what-creek.com) Received: by what-creek.com (Postfix, from userid 102) id C627D140EC03; Sat, 4 Nov 2006 07:00:47 +0000 (GMT) Date: Sat, 4 Nov 2006 07:00:47 +0000 From: John Birrell To: FreeBSD Tinderbox Message-ID: <20061104070047.GA98215@what-creek.com> References: <20061104060421.6145773068@freebsd-current.sentex.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20061104060421.6145773068@freebsd-current.sentex.ca> User-Agent: Mutt/1.4.2.1i Cc: current@freebsd.org, sparc64@freebsd.org Subject: Re: [head tinderbox] failure on sparc64/sun4v X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 04 Nov 2006 06:59:23 -0000 On Sat, Nov 04, 2006 at 01:04:21AM -0500, FreeBSD Tinderbox wrote: > [...] > /src/sys/netinet/sctp_pcb.c:3394: warning: previous implicit declaration of 'atomic_add_16' was here > /src/sys/netinet/sctp_pcb.c:3470: warning: nested extern declaration of `atomic_add_16' > /src/sys/netinet/sctp_pcb.c:3394: warning: redundant redeclaration of 'atomic_add_16' > /src/sys/netinet/sctp_pcb.c:3394: warning: previous implicit declaration of 'atomic_add_16' was here > /src/sys/netinet/sctp_pcb.c: In function `sctp_load_addresses_from_init': > /src/sys/netinet/sctp_pcb.c:4382: warning: nested extern declaration of `atomic_add_16' > /src/sys/netinet/sctp_pcb.c:3394: warning: redundant redeclaration of 'atomic_add_16' > /src/sys/netinet/sctp_pcb.c:3394: warning: previous implicit declaration of 'atomic_add_16' was here > *** Error code 1 This is a problem on sparc64 and sun4v because we don't have an atomic_add_16. I looked at the code in Solaris to see what asm is required to implement it and it takes 22 statements compared to 2 for a 64 bit variable and 4 for a 32 bit variable. Can't the code be changed to use a more typical variable size of the arches we have? 32 bits would be a better choice. -- John Birrell