From owner-svn-src-all@freebsd.org Tue Nov 6 20:13:52 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBB33112FCF3; Tue, 6 Nov 2018 20:13:51 +0000 (UTC) (envelope-from markiyan.kushnir@gmail.com) Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0522F6BD1F; Tue, 6 Nov 2018 20:13:51 +0000 (UTC) (envelope-from markiyan.kushnir@gmail.com) Received: by mail-io1-xd2e.google.com with SMTP id 79-v6so10222655iou.2; Tue, 06 Nov 2018 12:13:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hANb27LVd5l6beyz+fK9Pgh9w6ulISKZ1PuSm7/G8do=; b=nIuvKMufkVBMzikF5wLxCHw3c4GXpbLj9R+5f6MMb/Wd6H9v2Hn3f/0A30O2jgHbYo hTj623Twc52Iy8Tg4RfYtq0mRmx4RwCRglpnENZesfFzMPLOi5VSSYVN7hymqcwLBa0g ugDlJ1SPU4OhLq600+GMcyAc7gCPT6l8V76sALpNbJV0NnbS4tHU1OPG3G6NSOq2hNB6 dE0SANFeqBP6b2gqVujWcI7g/dM1ELLABueglpT6XZ62g3TRcB4ZyvKWOu5rxwWKt19u tXTfcw7iT+aHEtWycdcjKol2Qu8HSlmp+vW+1+G+ZpjJEJaJpG+ym6wzDG0OISOPE8GK Hy9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hANb27LVd5l6beyz+fK9Pgh9w6ulISKZ1PuSm7/G8do=; b=EDTIym8GGPkcY67Kz1nJ8jvxphzHkxdMrENPrYqdWStgUVTkDCb50Mfz/DhcnJJZYK JRV4iP4AqQ5AceXFxhnjw+IEkXxNqYsG2a7tZk1h/tyrJowsccZKKoJVq5tW+lSA+cBl 9tN+WEIDC1X7L0MSrpnabrdGl+Yn5oznD1c8Twqc2E6/R812cU9d4/W2F766l26RWNuF /QN0U82OiDal8zLvM7wAEZGkTE8xBhyl7clGSQ8uVGyEGVUg53fsNTVfHPRpOtfR+6TB XgYsBtUo2lubi4bDx+lV/UdWwRZC+yNDVgbx9Dmrpw76R2yLqGvM9lRRYm9hPhPHZCfT sdPQ== X-Gm-Message-State: AGRZ1gKsW7IVjuiOeGoRKjNKw3ytHbxd6hNGhhZIdHSEj3lt50n1n7jf jbzhFGc09TQU4+cQrV/tsX2WK32sIa4a4U9+bP1h+eO0ItE= X-Google-Smtp-Source: AJdET5czC0OJGUUhwrB3rOobm1WttIFvjBHptjuU3cF0IgmlSzIxwtV16wa955ogQrs11mCGVyvhNVw5FYEthiD1DP8= X-Received: by 2002:a6b:5503:: with SMTP id j3-v6mr21557783iob.209.1541535230007; Tue, 06 Nov 2018 12:13:50 -0800 (PST) MIME-Version: 1.0 References: <201810230631.w9N6VPR4008554@repo.freebsd.org> <9612d267-91dc-b1ee-7530-284376f08f08@FreeBSD.org> In-Reply-To: From: Markiyan Kushnir Date: Tue, 6 Nov 2018 22:13:38 +0200 Message-ID: Subject: Re: svn commit: r339636 - in head: . share/mk To: arichardson@freebsd.org Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-Rspamd-Queue-Id: 0522F6BD1F X-Spamd-Result: default: False [-3.42 / 200.00]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; TO_DN_NONE(0.00)[]; URI_COUNT_ODD(1.00)[15]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; MX_GOOD(-0.01)[cached: alt3.gmail-smtp-in.l.google.com]; NEURAL_HAM_SHORT(-0.93)[-0.929,0]; FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.961,0]; R_DKIM_ALLOW(-0.20)[gmail.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.993,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; IP_SCORE(-0.52)[ipnet: 2607:f8b0::/32(-1.17), asn: 15169(-1.37), country: US(-0.08)]; RCVD_IN_DNSWL_NONE(0.00)[e.2.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_COUNT_TWO(0.00)[2] X-Rspamd-Server: mx1.freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Nov 2018 20:13:52 -0000 Here it is. Environment: # env SSH_CLIENT=3D10.1.2.10 43379 22 REPLYTO=3Dmarkiyan.kushnir@gmail.com LSCOLORS=3Dgxfxcxdxbxegedabagacad LOGNAME=3Droot PAGER=3Dless MAIL=3D/var/mail/root PATH=3D/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/b= in EDITOR=3Dvim ENV=3D/root/.shrc SSH_AUTH_SOCK=3D/tmp/ssh-vx8WNc4TSI/agent.56491 PWD=3D/root TERM=3Dxterm-256color SSH_TTY=3D/dev/pts/0 HOME=3D/root USER=3Droot GREP_COLOR=3D1;31 SSH_CONNECTION=3D10.1.2.10 43379 10.1.2.150 22 COLORTERM=3D1 SHELL=3D/bin/sh BLOCKSIZE=3DK # cat /etc/make.conf MALLOC_PRODUCTION=3Dtrue .if ${.CURDIR:M*/multimedia/ffmpeg} CFLAGS +=3D -ffast-math -fno-finite-math-only .endif # cat /etc/src.conf WITHOUT_ATM=3Dok WITH_BSD_GREP=3Dok WITHOUT_CROSS_COMPILER=3Dok WITH_CTF=3Dok WITHOUT_DMAGENT=3Dok WITH_EXTRA_TCP_STACKS=3Dok WITHOUT_FLOPPY=3Dok WITHOUT_GNU_DIFF=3Dok WITHOUT_GNU_GREP=3Dok WITHOUT_LIB32=3Dok WITHOUT_LLVM_TARGET_ALL=3Dok WITH_LOADER_LUA=3Dok WITHOUT_MAIL=3Dok # rm -Rf /usr/obj/* # cd /usr/src && /usr/bin/make cleandir # cd /usr/src && /usr/bin/make BUILD_WITH_STRICT_TMPPATH=3D0 buildworld TARGET=3Damd64 yes, "BUILD_WITH_STRICT_TMPPATH=3D0" fixed buildworld, it has just passed 3= .1 stage, now running as usual... -- Markiyan =D0=B2=D1=82, 6 =D0=BB=D0=B8=D1=81=D1=82. 2018 =D0=BE 19:37 Alexander Richa= rdson =D0=BF=D0=B8=D1=88=D0=B5: > Hi Markiyan, > > > This looks exactly like the SYSTEM_COMPILER/SYSTEM_LINKER build failure > that should have been fixed by r340167. > Does passing BUILD_WITH_STRICT_TMPPATH=3D0 on the make command line fix t= he > build error? If so it seems like I missed one more SYSTEM_COMPILER case. > > Could you send me your buildworld command+environment variables so I can > see what's going wrong? > > Thanks, > Alex > > > On Tue, 6 Nov 2018 at 17:12 Markiyan Kushnir > wrote: > >> Alexander, >> >> Cannot tell exactly what change it was, might be one of your recent >> changes to bsd.compiler.mk or Makefile.inc1? ... >> >> Now running "make buildworld" I can proceed with "3.1: recording build >> metadata" only having USING_SYSTEM_COMPILER=3Dyes USING_SYSTEM_LINKER=3D= yes set >> in my environment. Otherwise I'm getting this: >> >> sh: cc: not found >> make[2]: "/work/src.svn/share/mk/bsd.compiler.mk" line 176: Unable to >> determine compiler type for CC=3Dcc -target x86_64-unknown-freebsd13.0 >> --sysroot=3D//usr/obj/work/src.svn/amd64.amd64/tmp >> -B//usr/obj/work/src.svn/amd64.amd64/tmp/usr/bin. Consider setting >> COMPILER_TYPE. >> *** Error code 1 >> >> Stop. >> make[1]: stopped in /work/src.svn >> *** Error code 1 >> >> Stop. >> make: stopped in /work/src.svn >> Failed to build world >> >> I'm at rev. 340189. Could you please have a look? >> >> -- >> Markiyan >> >> =D0=B2=D1=82, 6 =D0=BB=D0=B8=D1=81=D1=82. 2018 =D0=BE 01:11 Alexander Ri= chardson >> =D0=BF=D0=B8=D1=88=D0=B5: >> >>> On Mon, 5 Nov 2018 at 23:00, Bryan Drewery wrote= : >>> > >>> > On 10/22/2018 11:31 PM, Alex Richardson wrote: >>> > > Author: arichardson >>> > > Date: Tue Oct 23 06:31:25 2018 >>> > > New Revision: 339636 >>> > > URL: https://svnweb.freebsd.org/changeset/base/339636 >>> > > >>> > > Log: >>> > > Only compute the X_COMPILER_*/X_LINKER_* variables when needed >>> > > >>> > > When building CheriBSD we have to set XLD/XCC/XCFLAGS on the >>> command line. >>> > > This triggers the $XCC !=3D $CC case in bsd.compiler.mk (and the >>> same for LD >>> > > in bsd.linker.mk) which causes it to call ${XCC} --version and >>> > > ${XLD} --version (plus various awk+sed+echo calls) in every >>> subdirectory. >>> > > For incremental builds and stages that only walk the source tree >>> this is >>> > > often the majority of the time spent in that directory. >>> > > >>> > ... >>> > >>> > > By only computing the value of the X_COMPILER_*/X_LINKER_* >>> variables if >>> > > _WANT_TOOLCHAIN_CROSS_VARS is set we can reduce the number of >>> cc/ld calls >>> > > to once per build stage instead of once per recursive make. >>> > >>> > This sounds wrong. bsd.compiler.mk *already* handles that kind of >>> thing >>> > by exporting its computations. Adding a second hack for a similar >>> > problem isn't the right solution. >>> > >>> >>> I added debug .info statements for every time bsd.compiler.mk was >>> running cc --version and it was always running it for $XCC during make >>> buildworld. >>> As far as I can tell this happens because $CC and $XCC no longer match. >>> I believe the problem is that the toplevel makefile runs the cross >>> stages with CC=3D"${XCC} ${XCFLAGS}" so if you have XCFLAGS set in your >>> environment $CC will never be equal to $XCC. >>> This also means there is not cached variable for $XCC since it was >>> computed for "${XCC} ${XCFLAGS}" rather than $XCC . >>> >>> This patch massively reduced the incremental build time for CheriBSD >>> but if you can suggest I better fix that would be great. >>> >>> Alex >>> >> _______________________________________________ >>> svn-src-all@freebsd.org mailing list >>> https://lists.freebsd.org/mailman/listinfo/svn-src-all >>> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >>> >>