Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 5 Sep 2022 15:44:01 +0200
From:      Gordon Bergling <gbe@freebsd.org>
To:        Jessica Clarke <jrtc27@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org>
Subject:   Re: git: 7d91d6b83e74 - main - stand: Grammar fix for a source code comment
Message-ID:  <YxX9IaktADUIzYqt@lion.ttyv0.de>
In-Reply-To: <49C52799-1277-499A-AD14-B4B3C1427097@freebsd.org>
References:  <202209041526.284FQxxW046404@gitrepo.freebsd.org> <49C52799-1277-499A-AD14-B4B3C1427097@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Sep 04, 2022 at 10:38:16PM +0100, Jessica Clarke wrote:
> On 4 Sept 2022, at 16:26, Gordon Bergling <gbe@FreeBSD.org> wrote:
> > 
> > The branch main has been updated by gbe (doc committer):
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=7d91d6b83e74edf278dde375e6049aca833cbebd
> > 
> > commit 7d91d6b83e74edf278dde375e6049aca833cbebd
> > Author:     Gordon Bergling <gbe@FreeBSD.org>
> > AuthorDate: 2022-09-04 15:26:48 +0000
> > Commit:     Gordon Bergling <gbe@FreeBSD.org>
> > CommitDate: 2022-09-04 15:26:48 +0000
> > 
> >    stand: Grammar fix for a source code comment
> > 
> >    - s/that that/that this/
> > 
> >    MFC after:      3 days
> > ---
> > stand/ficl/ficl.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/stand/ficl/ficl.h b/stand/ficl/ficl.h
> > index 97cf00b0dff3..45403824ad8f 100644
> > --- a/stand/ficl/ficl.h
> > +++ b/stand/ficl/ficl.h
> > @@ -149,7 +149,7 @@
> > **   inner loop. I'll look at it for ficl 3.0
> > ** - Make the main hash table a bigger prime (HASHSIZE)
> > ** - FORGET about twiddling the hash function - my experience is
> > -**   that that is a waste of time.
> > +**   that this is a waste of time.
> 
> I wouldn’t say either one is incorrect; if anything I’d say the
> existing comment is more natural (and likely what I would say).
> 
> Jess

Thanks for the feedback, reverted in 3c6db09bf45fd48e5e3c207f138ae1914dbeed0c.

--Gordon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YxX9IaktADUIzYqt>