From owner-freebsd-java@FreeBSD.ORG Mon May 7 11:16:47 2012 Return-Path: Delivered-To: freebsd-java@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A2736106566C for ; Mon, 7 May 2012 11:16:47 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id D623C8FC0A for ; Mon, 7 May 2012 11:16:46 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id OAA04444; Mon, 07 May 2012 14:16:34 +0300 (EEST) (envelope-from avg@FreeBSD.org) Message-ID: <4FA7AF11.6060108@FreeBSD.org> Date: Mon, 07 May 2012 14:16:33 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:12.0) Gecko/20120503 Thunderbird/12.0.1 MIME-Version: 1.0 To: Greg Lewis References: <20120502064955.GA35530@misty.eyesbeyond.com> In-Reply-To: <20120502064955.GA35530@misty.eyesbeyond.com> X-Enigmail-Version: 1.5pre Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-java@FreeBSD.org Subject: Re: Fwd: cvs commit: ports/java/openjdk6 Makefile ports/java/openjdk6/files patch-ZoneInfoFile.java X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 May 2012 11:16:47 -0000 on 02/05/2012 09:49 Greg Lewis said the following: > FYI. > > I'm going to let this bake for a couple of days in openjdk6. This fixed > the problems I could reproduce with building eclipse. Please let me know > if you see any time zone related weirdness. If not I'll also apply the > patch to the other source ports (jdk15, jdk16 and openjdk7). Greg, thank you very much for this fix! > ----- Forwarded message from Greg Lewis ----- > > Date: Wed, 2 May 2012 06:13:16 +0000 (UTC) > From: Greg Lewis > To: ports-committers@freebsd.org, cvs-ports@freebsd.org, cvs-all@freebsd.org > Subject: cvs commit: ports/java/openjdk6 Makefile ports/java/openjdk6/files > patch-ZoneInfoFile.java > > glewis 2012-05-02 06:13:16 UTC > > FreeBSD ports repository > > Modified files: > java/openjdk6 Makefile > Added files: > java/openjdk6/files patch-ZoneInfoFile.java > Log: > . Fix the look up of time zone data when TZUPDATE is turned on and as a > result turn it on by default again. This change bears a little more > explanation. > > In UnixFileSystem.java there is a cache of canonical paths and in > particular one for paths inside java.home. The problem with looking > up time zone data is that if another path within java.home has been > looked up then the symlink for the time zone data is not resolved > (since the cache assumes there are no symlinks in java.home) and we fail > to be able to open the ZoneInfoMapping file. > > One of the other features in UnixFileSystem is that the cache is not > consulted and full resolution occurs for paths containing "." or "..". > I've chosen to (ab)use this to force resolution of the time zone data > directory in ZoneInfoFile.java rather than doing something like IcedTea > did which was to introduce a tz.properties file where they would stash > the time zone info directory rather than symlinking it in. For full > reference that patch is here: > > http://icedtea.classpath.org/hg/icedtea6/file/tip/patches/use-system-tzdata.patch > > There are two main reasons I chose a bit of a hack rather than something > like this. > > 1. I want to apply the patch to non-GPL'ed code (e.g. the jdk16 port). > 2. Using updated time zone data is only an option in the port and using > something like tz.properties when the option is off is clunky. > > Thanks to avg@ for sleuth work on finding the bug write up and the > IcedTea fix. > > Revision Changes Path > 1.60 +2 -2 ports/java/openjdk6/Makefile > 1.1 +14 -0 ports/java/openjdk6/files/patch-ZoneInfoFile.java (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/java/openjdk6/Makefile.diff?&r1=1.59&r2=1.60&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/java/openjdk6/files/patch-ZoneInfoFile.java > > ----- End forwarded message ----- > -- Andriy Gapon