From nobody Fri Dec 5 14:58:20 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dNDyh59d9z6Hxhj for ; Fri, 05 Dec 2025 14:58:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dNDyh4Zq1z3rDT for ; Fri, 05 Dec 2025 14:58:20 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764946700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FyTgzptbRAcQ9E3+MyQ1pijBQIw6k+wNdctSNgRmknA=; b=q9He914921UKQcML8W+WHTbXnWrHtNRtGf447SPP2RQGtD+8zXaWwHQcw2EUOp/z7Ths0X 3M3/9dyCUaLhX6vgtjxyuOXpG3pYOvd3Xmk8jfPWPOxFsRh5+lCI+0lR19LpElYUQfjVjy 0TSW0UJ67qP6Vw5cGUyCtqtbO6vIrAu+sg/la089d/dyicMdGliBYYRJY1oMinm9JkF/im pKBfUIJlYgfv2C981E/md8UxEp/y2nb5tnsxacoDSuD1ODTIj+Lh3gQv+Xdj66QFkaZKQK /UI5ThS70KSFbnqcrd9o4iGzYj2bwRdmW0hbBbaNm30AFwpjkDmXkB8bOgBsrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1764946700; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FyTgzptbRAcQ9E3+MyQ1pijBQIw6k+wNdctSNgRmknA=; b=dTyKIByLD9td9A+zGrQXtRB0zc2i8w0UheBvDPISUsPGLpd0aYTrSt1m6iSoK+4C4o0FYp jGCEx2E1+xPB7GcQMyfdLoITjiVtdyFCmcyftHSyvYy8vUHlr86MZeTuk6lzhfOCfsvckH HgHDpJyoCwYFSLpLiOPQAYP86eTObtpnN/GzF1jer8GZdwUKWJ7dhXmBR2L3+UPfT59Os2 D7WF5c0O1Q9674BuxgeZocooU1v20o1qO7XSWrdE83Ymllhfaui9d0dszduTaxlCXVcGLv uifIUPPzHa07Hzo3ytosgUhIwmt//XpEgv4A+7Asn/rASDyocqJmKJFPkCIH5Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1764946700; a=rsa-sha256; cv=none; b=EU2GpeHpcVa/Kg4kxYfG7ZRRuYmGev4KjMVNLVhhcAr81ktlmCSlATvzxCnJPovzfRpFBo Bp7E1R5/3JZ80BM05vqOGaZ/eJr7YgHkhfnH9JuUah7e3CGrVU8V30W3+MzbS2SisfJshs F8YZk8AI7Iq+RRlEeoXRYk6bh9cj+68oiGFv/jtbpt3d7vnwABtmi6f+FyBn5aS848lHKj 5jKE0A2zQaBfQqc/byM2lCnUJSv6mJOzfcP4HakYp+R9YNwxSIUZVGZxwzZ4m6TI3MKZEN wleE3Zu/rXwabfe47FFRidSf5TA30ffAsMZpvb9N8p8Y67wNVbK3jVMOzCXoSw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dNDyh3tPzz6b for ; Fri, 05 Dec 2025 14:58:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32a51 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 05 Dec 2025 14:58:20 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: 4c2295c15860 - main - bus: Return 0 if reading an ivar fails List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4c2295c15860e70c8bd3f05f9229d2fc40dfd50d Auto-Submitted: auto-generated Date: Fri, 05 Dec 2025 14:58:20 +0000 Message-Id: <6932f30c.32a51.5317e0b2@gitrepo.freebsd.org> The branch main has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=4c2295c15860e70c8bd3f05f9229d2fc40dfd50d commit 4c2295c15860e70c8bd3f05f9229d2fc40dfd50d Author: Dag-Erling Smørgrav AuthorDate: 2025-12-05 14:57:37 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2025-12-05 14:57:37 +0000 bus: Return 0 if reading an ivar fails In the non-INVARIANTS case, return 0 rather than stack garbage if reading an ivar fails (in the INVARIANTS case, we still panic). MFC after: 1 week Sponsored by: Klara, Inc. Sponsored by: NetApp, Inc. Reviewed by: jhb Differential Revision: https://reviews.freebsd.org/D54078 --- sys/sys/bus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/sys/bus.h b/sys/sys/bus.h index e0c6c590ce8d..86afc53da562 100644 --- a/sys/sys/bus.h +++ b/sys/sys/bus.h @@ -933,7 +933,7 @@ DECLARE_MODULE(_name##_##busname, _name##_##busname##_mod, \ static __inline type \ varp ## _get_ ## var(device_t dev) \ { \ - uintptr_t v; \ + uintptr_t v = 0; \ int e __diagused; \ e = BUS_READ_IVAR(device_get_parent(dev), dev, \ ivarp ## _IVAR_ ## ivar, &v); \