From owner-svn-src-all@freebsd.org Thu Oct 26 23:04:26 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F23C3E5518C; Thu, 26 Oct 2017 23:04:26 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x236.google.com (mail-lf0-x236.google.com [IPv6:2a00:1450:4010:c07::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 741CA6D779; Thu, 26 Oct 2017 23:04:26 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x236.google.com with SMTP id 75so5478128lfx.1; Thu, 26 Oct 2017 16:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=pN50OAiAlEkkPETO8KEOv2eVANtB/3pWAqB9BvEN+4U=; b=fMfK5b8+/FRxiWrIxUdxxJxsUqanEsqK3vxu4KfnJnlVgjKHhnXP30zBSyVmC2Cemw DFwp1zoUxRUFQ5MRTLJZdcpYQTdFAxCY4+8DRVkLED9iDTAUecXzkCK1PoGiHSGQvEN0 vg/+R0C8n4iA/G1v3E62rwDT9TzT19PpfG8gYve1f3AbycRMBVINeBFojgoAwXOQE+kr W47JJDUAySorKbf4Zi+Sk2RwvO7+QsaRS+4Vwsq3uU7mXpotwFXfJtePVG17GKCk7i4j xOHenGFMzbiguXo57iHNGi/j8fom7QnCmBbnC2lffqxUtU1admAkqVv4BKxT1D+mGEzS cioQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=pN50OAiAlEkkPETO8KEOv2eVANtB/3pWAqB9BvEN+4U=; b=T7NEfl4/YZR+o9cL55JzBmYrJot5+1Y8I17c78jH46z9g9EuazU3QmE1jegwOD95gj k6ZineY1cQX8LlwPQH8YbzsFQBbYpulXY/OoPWiBNJ3eqDWsasJb4JVl4bvt6l4+o/qv cuBOudSlNeadpm/6+SSyOhl/PMWtqzyEsFvPqU2AlnYk61YLYfF1pP7QONJ0g1O78lRQ UcwoxMb6Li5JPtjRVe6m7CGEayoYwzIGXp1bd6lhfOer4ZDSYDW/vAHtv10oPa/BhAzh 9rrNqccXdFJQBglciFBlEQdC9df7d64o8MPc51xkKYlLic3NS9m78lKdt5rLU+NXREeu uEHQ== X-Gm-Message-State: AMCzsaVOEFmcgou/Pzc3XfdsFkYj0hfDMIudW91xuPKNlxTgoRif7vIn BPst5Y/l3A2auAqqhyxBugxf/cf+tfQMsmGb/i0= X-Google-Smtp-Source: ABhQp+R26777PlJGWGfm+UumdiMrhMAbX3MkQAxPFY6bX6Yoi66HUWsHtUiLbaAM9LjlnfUx3SH4NNIXhJBbWgY2ks4= X-Received: by 10.46.20.11 with SMTP id u11mr10477414ljd.38.1509059064224; Thu, 26 Oct 2017 16:04:24 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.93.24 with HTTP; Thu, 26 Oct 2017 16:04:23 -0700 (PDT) In-Reply-To: <201710262253.v9QMrovZ009495@repo.freebsd.org> References: <201710262253.v9QMrovZ009495@repo.freebsd.org> From: Alan Somers Date: Thu, 26 Oct 2017 17:04:23 -0600 X-Google-Sender-Auth: 9cQX5WLCQ_CDU09r9-CSfuQRyKU Message-ID: Subject: Re: svn commit: r325026 - head/sys/cam/ata To: Warner Losh Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Oct 2017 23:04:27 -0000 On Thu, Oct 26, 2017 at 4:53 PM, Warner Losh wrote: > Author: imp > Date: Thu Oct 26 22:53:49 2017 > New Revision: 325026 > URL: https://svnweb.freebsd.org/changeset/base/325026 > > Log: > Always send STANDBY IMMEDIATE when shutting down > > To save SMART data and for a drive to understand that it's been nicely > shutdown, we need to send a STANDBY IMMEDIATE. Modify adaspindown to > use a local CCB on the stack. When we're panicing, used > xpt_polled_action rather than cam_periph_runccb so that we can SEND > IMMEDIATE after we've shutdown the scheduler. > > Sponsored by: Netflix > Reviewed by: scottl@, gallatin@ > Differential Revision: https://reviews.freebsd.org/D12799 > > Modified: > head/sys/cam/ata/ata_da.c Will this put the drive into a standby state just prior to a warm reboot? That could cause lengthy delays on the new boot while the drives spin up. That behavior caused a problem when the mpr driver did it to a JBOD full of 96 SATA drives. On the new boot, each drive spun up one at a time while they were being probed. Eventually the system paniced because run_interrupt_driven_hooks timed out. With mpr, I was able to fix the problem by setting hw.mpr.enable_ssu=0. -Alan