From owner-freebsd-audit Wed Aug 22 1:50:49 2001 Delivered-To: freebsd-audit@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id 57E5B37B401 for ; Wed, 22 Aug 2001 01:50:44 -0700 (PDT) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f7M8oOL24892; Wed, 22 Aug 2001 11:50:24 +0300 (EEST) (envelope-from ru) Date: Wed, 22 Aug 2001 11:50:24 +0300 From: Ruslan Ermilov To: cjclark@alum.mit.edu Cc: freebsd-audit@FreeBSD.ORG Subject: Re: syslogd(8) Hostname Upgrade Message-ID: <20010822115024.A23430@sunbay.com> References: <20010822013841.A76483@blossom.cjclark.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010822013841.A76483@blossom.cjclark.org>; from cristjc@earthlink.net on Wed, Aug 22, 2001 at 01:38:41AM -0700 Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Aug 22, 2001 at 01:38:41AM -0700, Crist J. Clark wrote: [...] > + if (gethostname(LocalHostName, sizeof(LocalHostName))) Check explicitly against -1. > + err(EX_OSERR, "gethostname failed"); Add "()" after "gethostname". > + if (signo && strcmp(oldLocalHostName, LocalHostName)) { I'm always confused when seeing this. IMHO, ``strcmp(...) != 0'' is much better. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message