From owner-freebsd-bugs@FreeBSD.ORG Wed Sep 12 14:00:13 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BD4EC1065675 for ; Wed, 12 Sep 2012 14:00:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8643C8FC14 for ; Wed, 12 Sep 2012 14:00:13 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8CE0DRN039203 for ; Wed, 12 Sep 2012 14:00:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8CE0DHP039190; Wed, 12 Sep 2012 14:00:13 GMT (envelope-from gnats) Resent-Date: Wed, 12 Sep 2012 14:00:13 GMT Resent-Message-Id: <201209121400.q8CE0DHP039190@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, nemysis Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B9330106566C for ; Wed, 12 Sep 2012 13:59:51 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 8A23F8FC15 for ; Wed, 12 Sep 2012 13:59:51 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q8CDxpMW095489 for ; Wed, 12 Sep 2012 13:59:51 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q8CDxp89095488; Wed, 12 Sep 2012 13:59:51 GMT (envelope-from nobody) Message-Id: <201209121359.q8CDxp89095488@red.freebsd.org> Date: Wed, 12 Sep 2012 13:59:51 GMT From: nemysis To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/171573: UnZip is in FreeBSD Base but many Ports use archivers/unzip X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Sep 2012 14:00:14 -0000 >Number: 171573 >Category: misc >Synopsis: UnZip is in FreeBSD Base but many Ports use archivers/unzip >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Sep 12 14:00:13 UTC 2012 >Closed-Date: >Last-Modified: >Originator: nemysis >Release: FreeBSD 9.0-RELEASE amd64 >Organization: >Environment: FreeBSD FreeBSD_Ports 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: UnZip is in FreeBSD Base http://www.freebsd.org/cgi/cvsweb.cgi/src/usr.bin/unzip/ But many Ports use as dependency archivers/unzip There are, which tried too make a Solution http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/166608 For older FreeBSD Versions must be a dependency in Ports .if (${OSVERSION} >= 900000 && ${OSVERSION} < 900012) || ${OSVERSION} < 800505) EXTRACT_DEPENDS+= unzip:${PORTSDIR}/archivers/unzip .endif Have tried this with RedPorts https://redports.org/buildarchive/20120912123031-57191/ >How-To-Repeat: grep -r /bin/unzip /usr/ports /usr/ports/Mk/bsd.commands.mk:UNZIP_CMD?= ${LOCALBASE}/bin/unzip /usr/ports/Mk/bsd.port.mk:PATCH_DEPENDS+= ${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip /usr/ports/Mk/bsd.port.mk:EXTRACT_DEPENDS+= ${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip /usr/ports/archivers/file-roller/Makefile: ${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip /usr/ports/archivers/file-roller/files/patch-src_fr-command-zip.c:+ fr_process_begin_command (comm->process, "%%LOCALBASE%%/bin/unzip"); /usr/ports/archivers/file-roller/files/patch-src_fr-command-zip.c:+ fr_process_begin_command (comm->process, "%%LOCALBASE%%/bin/unzip"); /usr/ports/archivers/file-roller/files/patch-src_fr-command-zip.c:+ fr_process_begin_command (comm->process, "%%LOCALBASE%%/bin/unzip"); /usr/ports/archivers/file-roller/files/patch-src_fr-command-zip.c:+ fr_process_begin_command (comm->process, "%%LOCALBASE%%/bin/unzip"); /usr/ports/audio/csound/Makefile:EXTRACT_DEPENDS+=${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip /usr/ports/audio/xmp/Makefile:RUN_DEPENDS+= ${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip .. >Fix: Please add to /usr/ports/Mk/bsd.port.mk .if defined(USE_ZIP) && ( (${OSVERSION} >= 900000 && ${OSVERSION} < 900012) || ${OSVERSION} < 800505 ) You find a diff. Patch attached with submission follows: --- bsd.port.mk.orig 2012-09-07 02:05:58.000000000 +0200 +++ bsd.port.mk 2012-09-12 15:36:11.000000000 +0200 @@ -1643,7 +1643,7 @@ .endif .endif -.if defined(USE_ZIP) +.if defined(USE_ZIP) && ( (${OSVERSION} >= 900000 && ${OSVERSION} < 900012) || ${OSVERSION} < 800505 ) EXTRACT_DEPENDS+= ${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip .endif .if defined(USE_XZ) && ( (${OSVERSION} >= 900000 && ${OSVERSION} < 900012) || ${OSVERSION} < 800505 ) >Release-Note: >Audit-Trail: >Unformatted: