From owner-svn-ports-all@freebsd.org  Tue May 24 10:05:36 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A6DDEB460C8;
 Tue, 24 May 2016 10:05:36 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 77BEA1EAD;
 Tue, 24 May 2016 10:05:35 +0000 (UTC)
 (envelope-from freebsd.contact@marino.st)
Received: from [192.168.1.21] (176.red-83-34-249.dynamicip.rima-tde.net
 [83.34.249.176])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 8B7DC43BB2;
 Tue, 24 May 2016 05:05:27 -0500 (CDT)
Subject: Re: svn commit: r415493 - in head/games/libretro-cores: . files
To: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
References: <201605190700.u4J70sfs011294@repo.freebsd.org>
From: John Marino <freebsd.contact@marino.st>
Reply-To: marino@freebsd.org
Message-ID: <307385ca-1cd1-83ae-1a66-b2a7210b5054@marino.st>
Date: Tue, 24 May 2016 12:05:25 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <201605190700.u4J70sfs011294@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 May 2016 10:05:36 -0000

On 5/19/2016 9:00 AM, Mathieu Arnold wrote:
> Author: mat
> Date: Thu May 19 07:00:54 2016
> New Revision: 415493
> URL: https://svnweb.freebsd.org/changeset/ports/415493
>
> Log:
>   Remove the use of :@, it must not be used before 9 goes out of support.
>
>   Incidentally, simplify quite a bit, and fix build on 9.
>
>   Sponsored by:	Absolight
>
> [snip]
> Modified: head/games/libretro-cores/Makefile
> ==============================================================================
> --- head/games/libretro-cores/Makefile	Thu May 19 06:28:48 2016	(r415492)
> +++ head/games/libretro-cores/Makefile	Thu May 19 07:00:54 2016	(r415493)
> [snip]
>
>  do-build:
>  	@for dir in ${CORE_DIRS}; do \
> -	  ${ECHO_MSG} "===>  Building for ${PKGNAME}: core $${dir} (`date`)"; \
> -	  if [ -f ${WRKSRC}/$${dir}/Makefile.freebsd ]; then \
> -	    (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD} ${MAKE_FLAGS} Makefile.freebsd ${_MAKE_JOBS} ${MAKE_ARGS}); \
> -	  elif [ -f ${WRKSRC}/$${dir}/Makefile.libretro ]; then \
> -	    (cd ${WRKSRC}/$${dir} && ${SETENV} ${MAKE_ENV} ${MAKE_CMD} ${MAKE_FLAGS} Makefile.libretro ${_MAKE_JOBS} ${MAKE_ARGS}); \
> +	  ${ECHO_MSG} "===>  Building for ${PKGNAME}: core ${dir} ($$(date))"; \
> +	  cd ${WRKSRC}/${dir}; \

We think this is a mistake:
changing "cd ${WRKSRC}/$${dir};" to "cd ${WRKSRC}/${dir};"
("core $${dir}" => "core ${dir}" is wrong too but that's only an echo issue)

I'm wondering how this is working on FreeBSD actually ...

John