From owner-svn-src-all@freebsd.org Fri Apr 1 09:08:21 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id ECF30AEB49D for ; Fri, 1 Apr 2016 09:08:21 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: from mail-lb0-x233.google.com (mail-lb0-x233.google.com [IPv6:2a00:1450:4010:c04::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7AA6D1976 for ; Fri, 1 Apr 2016 09:08:21 +0000 (UTC) (envelope-from zbb@semihalf.com) Received: by mail-lb0-x233.google.com with SMTP id u8so68128086lbk.0 for ; Fri, 01 Apr 2016 02:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZA8BGHz1+SC6N+b8FPyMsXn9U80wDink8GTdqZbjmXQ=; b=i+d0BA/5SLZP9UFLw0T0WzMGD7PaKWxX9WRdZE95tyAyr7906wz7kBCFsvRIH/hCl4 WiE1+epOQwAmLmqIh9XSDLJRC1AeHUzuwuDjtoELjzqEQWGhpCvohydAlRrLh9Jaw1fm 3ySXaZkYwF/Dvgh4auSxnYypzwn3KrgqCt0BwelSqEslpIw5wMJi4FqR6oElC8bp2/U+ MNEv1Q1OnLngMqPNKIG+1uXFehwl189RIaNZtFO1uiSc0DAd1unWNcm0a9OpuwCvByUR FPb5ROw9FZw2P+s4DMwNbg+m4Q4SDBNeZCoEvvNy8NraN716v4hQQSbC9RA0IBzZUruI s4ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZA8BGHz1+SC6N+b8FPyMsXn9U80wDink8GTdqZbjmXQ=; b=CCJp0hz9nsAzoseMLh6sDVwt8ALpU5114cg/GqP9PxFYdXsGNDAEXiXocQQ5RN4lBM 6ie0qkpzcwsaZCrjdTfmEw6iCzMWa9w3fYhYu+X/Bgs5vw3hVIO6JfQPyQ/ljvMLBiLl nV89z84PfjOluVp+vpY/JXZAud502WkL6MI8asY9q1ZZ9D1fpR4xSk/dXhXJC4/KJa/E qT9o2hWgTwzSf+/pRl6jxGnTdbEj0Ly6jEehuhcem1YTk9cMtmoCE8+HbbyULAL9IEHP 41k+WhWXHAlbpc/YwXKx9gWIaEJVOJ4Gj0mkbQPMVlF+1yTdJ7rXNL2HlF+ctVkwaSXq zMdA== X-Gm-Message-State: AD7BkJK63oiw9hO3LxdHtZUaaQpMm9ZDnk8iMnscXhkEgKu2CG0Qaxz8ux2VcAdF1Sm/L6Dqd5pNSxzqh3zzwA== X-Received: by 10.112.148.162 with SMTP id tt2mr1118611lbb.38.1459501699576; Fri, 01 Apr 2016 02:08:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.77.202 with HTTP; Fri, 1 Apr 2016 02:07:59 -0700 (PDT) In-Reply-To: <56FDBB36.5000302@freebsd.org> References: <201603291519.u2TFJuXW051571@repo.freebsd.org> <56FBE3D6.9050205@freebsd.org> <56FC0B55.1040805@freebsd.org> <56FDBB36.5000302@freebsd.org> From: Zbigniew Bodek Date: Fri, 1 Apr 2016 11:07:59 +0200 Message-ID: Subject: Re: svn commit: r297392 - in head/sys: conf dev/ofw powerpc/mpc85xx powerpc/powermac powerpc/pseries To: Nathan Whitehorn Cc: Ed Maste , Zbigniew Bodek , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 09:08:22 -0000 Thanks. Done: https://svnweb.freebsd.org/changeset/base/297486 Best regards zbb 2016-04-01 2:05 GMT+02:00 Nathan Whitehorn : > I seem to be wrong. In any event, we don't have any non-device-tree > platforms on PowerPC anymore, so you can just make it be "pci". > -Nathan > > On 03/31/16 01:18, Zbigniew Bodek wrote: > >> >> Are you sure? I don't see an example of what you are writing about. >> Instead I can see several other examples such as: >> >> dev/usb/controller/ehci_fsl.coptionalehci mpc85xx | ehci qoriq_dpaa >> dev/iicbus/adm1030.coptionalpowermac windtunnel | adm1030 powermac >> etc. >> >> Why would they do that if they could simply type: ehci mpc85xx | >> qoriq_dpaa? >> >> Best regards >> zbb >> >> 2016-03-30 19:22 GMT+02:00 Nathan Whitehorn > >: >> >> I think it should be pci aim | fdt, just like the previous line >> when the files lived in sys/powerpc. To conf, that evaluates as >> pci && (aim || fdt). >> -Nathan >> >> >> On 03/30/16 08:55, Zbigniew Bodek wrote: >> >>> >>> Thank you Nathan. Please check out new patch in the attachment. >>> >>> Best regards >>> zbb >>> >>> 2016-03-30 16:33 GMT+02:00 Nathan Whitehorn >>> >: >>> >>> PowerPC (and SPARC) can have real OFW without FDT support. >>> Adding FDT to LINT is the wrong solution: rather, it should >>> switch on fdt | aim like the rest of the Open Firmware code. >>> -Nathan >>> >>> >>> On 03/30/16 01:54, Zbigniew Bodek wrote: >>> >>>> Hello Ed, >>>> >>>> Please check out the attached patch. For powerpc we should >>>> compile-in ofwpci.c regardless of FDT option. >>>> However, it seems that LINT for powerpc does not have FDT. >>>> What do you thing about adding it (as can be seen in the >>>> attached patch)?. This would be done in a separate commit. >>>> >>>> Best regards >>>> zbb >>>> >>>> 2016-03-30 1:53 GMT+02:00 Ed Maste >>> >: >>>> >>>> On 29 March 2016 at 15:19, Zbigniew Bodek >>>> > wrote: >>>> > Author: zbb >>>> > Date: Tue Mar 29 15:19:56 2016 >>>> > New Revision: 297392 >>>> > URL: https://svnweb.freebsd.org/changeset/base/297392 >>>> > >>>> > Log: >>>> > Reduce OFW PCI code duplication - involves ARM, PPC >>>> and SPARC64 >>>> >>>> My 'make tinderbox' build is now failing (powerpc LINT) >>>> with: >>>> >>>> linking kernel >>>> cpcht.o: In function `cpcht_attach': >>>> cpcht.c:(.text+0x17dc): undefined reference to >>>> `ofw_pci_attach' >>>> cpcht.o:(.data.rel+0x0): undefined reference to >>>> `ofw_pci_driver' >>>> grackle.o: In function `grackle_attach': >>>> grackle.c:(.text+0x2dc): undefined reference to >>>> `ofw_pci_attach' >>>> grackle.o:(.data.rel+0x0): undefined reference to >>>> `ofw_pci_driver' >>>> uninorthpci.o: In function `uninorth_attach': >>>> uninorthpci.c:(.text+0x68c): undefined reference to >>>> `ofw_pci_attach' >>>> uninorthpci.o:(.data.rel+0x0): undefined reference to >>>> `ofw_pci_driver' >>>> *** [kernel] Error code 1 >>>> _______________________________________________ >>>> svn-src-all@freebsd.org >>>> mailing list >>>> https://lists.freebsd.org/mailman/listinfo/svn-src-all >>>> To unsubscribe, send any mail to >>>> "svn-src-all-unsubscribe@freebsd.org >>>> " >>>> >>>> >>>> >>> >>> >> >> >