From owner-cvs-all@FreeBSD.ORG Sat Jul 23 20:13:55 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 2936A106566B; Sat, 23 Jul 2011 20:13:55 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 65-241-43-4.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id CB03F150C2E; Sat, 23 Jul 2011 20:13:54 +0000 (UTC) Message-ID: <4E2B2B82.1020506@FreeBSD.org> Date: Sat, 23 Jul 2011 13:13:54 -0700 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:5.0) Gecko/20110723 Thunderbird/5.0 MIME-Version: 1.0 To: bf1783@gmail.com References: <201107200252.p6K2qZRb053515@repoman.freebsd.org> In-Reply-To: X-Enigmail-Version: 1.2pre OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "b. f." , cvs-all@freebsd.org, ports-committers@freebsd.org, cvs-ports@freebsd.org, riggs@rrr.de, Mario Sergio Fujikawa Ferreira Subject: Re: cvs commit: ports/multimedia/mencoder Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jul 2011 20:13:55 -0000 On 07/22/2011 23:07, b. f. wrote: > I must renew my plea to avoid these "fixes". When a user sets > WITH/WITHOUT_FOO, he means precisely "build this port > WITH/WITHOUT_FOO", and not "build this port WITH/WITHOUT_FOO, except > if package X is installed, and, if it is, silently do something else", > and we should not be adding code to do the latter. We should instead > patch the broken distribution configure scripts and Makefiles, so that > the problem does not occur. If a lack of time or another problem > prevents this from being done initially, then as a temporary > workaround, we should add something like: > > .if exists(${LOCALBASE}/lib/libass.so) && defined(WITHOUT_ASS) > BROKEN= libass is installed, so broken mplayer scripts will ignore WITHOUT_ASS > .endif > > so that the user will know that his choice of options cannot be used, > and he can take the appropriate action -- and he will not be misled > into thinking that his choice of options are used when they are not. +1 -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/