From owner-freebsd-current  Thu Sep 26 21:12:53 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3F04937B401
	for <current@freebsd.org>; Thu, 26 Sep 2002 21:12:51 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id 7840D43E42
	for <current@freebsd.org>; Thu, 26 Sep 2002 21:12:47 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 72472 invoked by uid 1000); 27 Sep 2002 04:12:49 -0000
Date: Thu, 26 Sep 2002 21:12:49 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Peter Wemm <peter@wemm.org>
Cc: current@freebsd.org
Subject: Re: alpha tinderbox failure 
In-Reply-To: <20020927001249.D054B2A894@canning.wemm.org>
Message-ID: <Pine.BSF.4.21.0209262111360.72301-100000@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Thu, 26 Sep 2002, Peter Wemm wrote:
> Nate Lawson wrote:
> > On Thu, 26 Sep 2002, Dag-Erling Smorgrav wrote:
> > > >>> Kernel build for LINT started on Thu Sep 26 15:50:41 PDT 2002
> > > --------------------------------------------------------------
> > > ===> vinum
> > > cc1: warnings being treated as errors
> > > /h/des/src/sys/dev/advansys/adv_pci.c: In function `adv_pci_attach':
> > > /h/des/src/sys/dev/advansys/adv_pci.c:197: warning: overflow in implicit co
>     nstant conversion
> > > *** Error code 1
> > > 
> > > Stop in /h/des/obj/h/des/src/sys/LINT.
> > > *** Error code 1
> > > 
> > > Stop in /h/des/src.
> > > *** Error code 1
> > > 
> > > Stop in /h/des/src.
> > 
> > I don't understand why this error occurs since the types all seem to
> > match.  
> > 
> > Relevant lines from src/sys/dev/advansys/adv_pci.c:
> > 
> >         /* Allocate a dmatag for our transfer DMA maps */
> >         /* XXX Should be a child of the PCI bus dma tag */
> >         error = bus_dma_tag_create(/*parent*/NULL, /*alignment*/1,
> >                                    /*boundary*/0,
> >                                    /*lowaddr*/ADV_PCI_MAX_DMA_ADDR,
> >                                    /*highaddr*/BUS_SPACE_MAXADDR,
> >                                    /*filter*/NULL, /*filterarg*/NULL,
> >                                    /*maxsize*/BUS_SPACE_MAXSIZE_32BIT,
> >                                    /*nsegments*/BUS_SPACE_UNRESTRICTED,
> >                                    /*maxsegsz*/ADV_PCI_MAX_DMA_COUNT,
> >                                    /*flags*/0,   
> > 197 ----->                         &adv->parent_dmat);
> > 
> 
> 
> gcc is telling you the wrong line.  The problem is here:
> 
> int nsegments;
> vs:
> /*nsegments*/BUS_SPACE_UNRESTRICTED,
> note that:
> bus.h:#define BUS_SPACE_UNRESTRICTED    (~0UL)
> 
> 0xffffffffffffffff will not fit in an int.

I looked at this some more.  Would it be ok to make it (~0) since we'll
never need 64 bits worth of nsegments?

-Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message