Date: Wed, 16 Jan 2002 11:00:02 -0800 (PST) From: Alexander Leidinger <Alexander@Leidinger.net> To: freebsd-ports@FreeBSD.org Subject: Re: ports/33945: [audio] lame update Message-ID: <200201161900.g0GJ02301659@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/33945; it has been noted by GNATS.
From: Alexander Leidinger <Alexander@Leidinger.net>
To: yoshiaki@kt.rim.or.jp
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: ports/33945: [audio] lame update
Date: Wed, 16 Jan 2002 19:50:48 +0100 (CET)
On 17 Jan, Yoshiaki Uchikawa wrote:
> diff -urN lame37/Makefile lame/Makefile
> --- lame37/Makefile Sun Dec 9 22:41:40 2001
> +++ lame/Makefile Thu Jan 17 01:14:26 2002
> @@ -6,35 +6,27 @@
> #
>
> PORTNAME= lame
> -PORTVERSION= 3.70
> -PORTREVISION= 2
> +PORTVERSION= 3.91
> +PORTREVISION= 1
No PORTREVISION needed.
> CATEGORIES= audio
> MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} \
> ftp://lame.sourceforge.net/pub/
> MASTER_SITE_SUBDIR= lame
> -DISTNAME= ${PORTNAME}${PORTVERSION}
> +DISTNAME= ${PORTNAME}-${PORTVERSION}
That's the default, you should remove DISTNAME completely.
Missing:
* BUILD_DEPENDS= nasm:${PORTSDIR}/devel/nasm
(LAME is faster with it.)
* INSTALLS_SHLIB= yes
> MAINTAINER= yoshiaki@kt.rim.or.jp
>
> USE_GMAKE= yes
LAME can now be used with make from the base system.
> -WANT_GTK= yes
> -ALL_TARGET= lame
> +HAS_CONFIGURE= yes
> +#WANT_GTK= yes
> +CONFIGURE_ARGS= --prefix=${LOCALBASE}
Doesn't "GNU_CONFIGURE" handle "--prefix"?
> MAN1= lame.1
>
> .include <bsd.port.pre.mk>
>
> -.if defined(HAVE_GTK)
> -USE_GTK= yes
> -.endif
> -
> -do-install:
> - @${INSTALL_PROGRAM} ${WRKSRC}/lame ${PREFIX}/bin
> - @${INSTALL_MAN} ${WRKSRC}/doc/man/lame.1 ${PREFIX}/man/man1
> -.if !defined(NOPORTDOCS)
> - @${MKDIR} ${PREFIX}/share/doc/lame
> - @${INSTALL_DATA} ${WRKSRC}/doc/html/*.html \
> - ${WRKSRC}/doc/html/*.css ${PREFIX}/share/doc/lame
> -.endif
> +#.if defined(HAVE_GTK)
> +#USE_GTK= yes
> +#.endif
>
> .include <bsd.port.post.mk>
The split into pre.mk and post.mk isn't needed.
> diff -urN lame37/files/patch-aa lame/files/patch-aa
[...]
> diff -urN lame37/files/patch-ab lame/files/patch-ab
cvs remove.
> diff -urN lame37/files/trash/patch-aa lame/files/trash/patch-aa
[...]
> diff -urN lame37/files/trash/patch-ab lame/files/trash/patch-ab
Backup of the above, shouldn't get committed.
> diff -urN lame37/pkg-plist lame/pkg-plist
> --- lame37/pkg-plist Sun Jul 8 16:25:54 2001
> +++ lame/pkg-plist Thu Jan 17 01:23:51 2002
> @@ -1,12 +1,16 @@
> bin/lame
> -%%PORTDOCS%%share/doc/lame/contributors.html
> -%%PORTDOCS%%share/doc/lame/examples.html
> -%%PORTDOCS%%share/doc/lame/history.html
> -%%PORTDOCS%%share/doc/lame/id3.html
> -%%PORTDOCS%%share/doc/lame/index.html
> -%%PORTDOCS%%share/doc/lame/lame.css
> -%%PORTDOCS%%share/doc/lame/node5.html
> -%%PORTDOCS%%share/doc/lame/node6.html
> -%%PORTDOCS%%share/doc/lame/node7.html
> -%%PORTDOCS%%share/doc/lame/switchs.html
> -%%PORTDOCS%%@dirrm share/doc/lame
> +include/lame/lame.h
> +lib/libmp3lame.so.0
> +lib/libmp3lame.la
This one shouldn't get installed (or remove it afterwards).
Missing:
* lib/libmp3lame.so
> +lib/libmp3lame.a
> +%%PORTDOCS%%share/doc/lame/html/basic.html
> +%%PORTDOCS%%share/doc/lame/html/contributors.html
> +%%PORTDOCS%%share/doc/lame/html/examples.html
> +%%PORTDOCS%%share/doc/lame/html/history.html
> +%%PORTDOCS%%share/doc/lame/html/id3.html
> +%%PORTDOCS%%share/doc/lame/html/index.html
> +%%PORTDOCS%%share/doc/lame/html/lame.css
> +%%PORTDOCS%%share/doc/lame/html/modes.html
> +%%PORTDOCS%%share/doc/lame/html/node6.html
> +%%PORTDOCS%%share/doc/lame/html/switchs.html
> +%%PORTDOCS%%@dirrm share/doc/lame/html
Missing:
* %%PORTDOCS%%@dirrm share/doc/lame
What about the ASCII docs (API, PRESETS.draft, README, TODO, USAGE) like
audio/lame-devel?
Bye,
Alexander.
--
Press every key to continue.
http://www.Leidinger.net Alexander @ Leidinger.net
GPG fingerprint = C518 BC70 E67F 143F BE91 3365 79E2 9C60 B006 3FE7
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200201161900.g0GJ02301659>