From owner-freebsd-current@FreeBSD.ORG  Sat Sep 12 09:03:59 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AA976106566B;
	Sat, 12 Sep 2009 09:03:59 +0000 (UTC)
	(envelope-from jh@saunalahti.fi)
Received: from gw02.mail.saunalahti.fi (gw02.mail.saunalahti.fi
	[195.197.172.116])
	by mx1.freebsd.org (Postfix) with ESMTP id 637E78FC0C;
	Sat, 12 Sep 2009 09:03:59 +0000 (UTC)
Received: from a91-153-125-115.elisa-laajakaista.fi
	(a91-153-125-115.elisa-laajakaista.fi [91.153.125.115])
	by gw02.mail.saunalahti.fi (Postfix) with SMTP id 34AF9139710;
	Sat, 12 Sep 2009 12:03:54 +0300 (EEST)
Date: Sat, 12 Sep 2009 12:03:53 +0300
From: Jaakko Heinonen <jh@saunalahti.fi>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20090912090353.GA806@a91-153-125-115.elisa-laajakaista.fi>
References: <4AA40E30.50109@FreeBSD.org> <4AAA9187.2020907@FreeBSD.org>
	<20090911210053.GA2090@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090911210053.GA2090@garage.freebsd.pl>
User-Agent: Mutt/1.5.19 (2009-01-05)
Cc: Kris Kennaway <kris@FreeBSD.org>,
	FreeBSD Current <freebsd-current@freebsd.org>, Kip Macy <kmacy@FreeBSD.org>
Subject: Re: panic: sx_xlock() of destroyed sx @
	/zoo/kris/src8/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/co
	mmon/fs/zfs/zfs_rlock.c:535
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 12 Sep 2009 09:03:59 -0000

On 2009-09-11, Pawel Jakub Dawidek wrote:
> > >panic: sx_xlock() of destroyed sx @ 
> > >/zoo/kris/src8/sys/modules/zfs/../../cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_rlock.c:535 
> 
> I was trying to reproduce it by doing much more frequent syncs and
> lowering vnodes limit, so they are inactivated more often, but I wasn't
> able to reproduce it.
> 
> The problem here is that we lock a range for the given znode, but before
> we unlock the range, znode is destroyed.

I wonder if this could be related to PR kern/132068 (i.e. zfs_zget() can
return reclaimed vnodes).

If you can reproduce the panic you could try this patch:

http://www.saunalahti.fi/~jh3/patches/zfs_zget-vnode-reclaim-race.diff

-- 
Jaakko