From owner-cvs-all  Tue Feb 25  7: 1:57 2003
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D1DC337B401; Tue, 25 Feb 2003 07:01:55 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 8542343FE3; Tue, 25 Feb 2003 07:01:55 -0800 (PST)
	(envelope-from des@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h1PF1t0U088221;
	Tue, 25 Feb 2003 07:01:55 -0800 (PST)
	(envelope-from des@repoman.freebsd.org)
Received: (from des@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h1PF1sYW088215;
	Tue, 25 Feb 2003 07:01:54 -0800 (PST)
Message-Id: <200302251501.h1PF1sYW088215@repoman.freebsd.org>
From: Dag-Erling Smorgrav <des@FreeBSD.org>
Date: Tue, 25 Feb 2003 07:01:54 -0800 (PST)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: cvs commit: src/usr.sbin/pkg_install/delete Makefile perform.c
X-FreeBSD-CVS-Branch: HEAD
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

des         2003/02/25 07:01:54 PST

  Modified files:
    usr.sbin/pkg_install/delete Makefile perform.c 
  Log:
  Fix a long-standing bug where if the package being deleted had no
  post-deinstall script, the variable intended to hold the name of that
  script would be used uninitialized.  In some cases, fexists() would
  succeed, causing pkg_delete to try to chmod +x it, then execute it,
  resulting in bizarre error messages such as:
  
  .//: Permission denied
  
  This bug would normally only occur when multiple packages were
  specified on the command line; otherwise post_script would be located
  in a previously unused part of the stack, and implicitly (but quite
  accidentally) initialized to all-zeros.
  
  MFC after:      3 days
  
  Revision  Changes    Path
  1.18      +1 -1      src/usr.sbin/pkg_install/delete/Makefile
  1.38      +11 -13    src/usr.sbin/pkg_install/delete/perform.c

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message