From nobody Thu Nov 16 00:49:03 2023 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4SW1cw301Nz50xGk for ; Thu, 16 Nov 2023 00:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SW1cw1y1Lz3gr8 for ; Thu, 16 Nov 2023 00:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1700095744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kpBDwruZ7giS1F3gXAxCJptBtPJuuRchA3/2/xkHTZw=; b=PsCNar89twC78KhmuM/l4MxudoTsGQyE+7tf6lXq0r/QT6h2vVU8VSuO5UnHm2UK62/3fy M9KmUZ8ShF/xAFnoZelM6Bu2czH9HwKJNkmCHcJKnbTd4md69IJJ4NEnnS5QMxZgQrDMn4 nnT4JYPBOuGiopMZ1A+IDt+Fj486Mg5WrloxmwZqXRSZrzdWVhuNaUbihCDJLAQmdaIPXI 0JytOwDsCjYXmZDlsmQNabb35XYUOsRYOs03Plgr8w7/BXICqOnEemI5Fq3dg14KKNOPln NyRMuSp59yM97oyEZDLJQp+ISJ7Z40QvZAZF+tJd81rD6K8uT5JvaIKyOHB28w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1700095744; a=rsa-sha256; cv=none; b=MDqfuyvHIid3MikVvbVBaVRzBSs2l6K5sL/SFkvFyoSIDJsU815ACKK4TNgJ+gJ4mq2OVE c0nyjGttA4GPaTZ1y2+6H/4SEQW2t7eR3+JIBAzfx0dIfKJ/KAZzzC+0iPpZrNIoZHOyoo yyjFWaQatva/lT8ocCC+Yeku5BJRE6GOXiA+3oYWvEDjPwb56wI5AraiHax3PHC8tTjbg4 Xo7NEcQTDBonqJ5YySIbhkWyeUMR1bZGYga43qThaHEHLZkYey8M3fPdpGMqiNW26h6egA PCmiX1hPtcJjfjS/OHIrX6ikSlH7akirzsECbaGEWrOEcuAlcalH3wV6vkNgqg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4SW1cw0w5hzfM1 for ; Thu, 16 Nov 2023 00:49:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3AG0n4Nv082006 for ; Thu, 16 Nov 2023 00:49:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3AG0n4kl082005 for net@FreeBSD.org; Thu, 16 Nov 2023 00:49:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 275002] if_wg: Missing failure check for m_copyback() Date: Thu, 16 Nov 2023 00:49:03 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: jhb@FreeBSD.org X-Bugzilla-Status: Closed X-Bugzilla-Resolution: Not A Bug X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_status resolution Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275002 John Baldwin changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Closed Resolution|--- |Not A Bug --- Comment #4 from John Baldwin --- Hmm, you could perhaps KASSERT that mget2() returned a chain of the proper length, but that's really just asserting that the API works as documented. = I'm not quite sure it's worth asserting after m_copyback as the length really shouldn't change. Other places in the tree that use the pattern of preallocating the mbuf chain by m_getm or m_get2 don't check the length aft= er m_copyback (linux_80211.c, iw_cxgbe/cm.c, gve_rx.c were ones I looked at), = so I don't think it's worth adding an assertion here. --=20 You are receiving this mail because: You are the assignee for the bug.=