From owner-cvs-src@FreeBSD.ORG Sat Mar 12 02:43:51 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2026916A4CE; Sat, 12 Mar 2005 02:43:51 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E696543D53; Sat, 12 Mar 2005 02:43:50 +0000 (GMT) (envelope-from mux@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j2C2hovR067521; Sat, 12 Mar 2005 02:43:50 GMT (envelope-from mux@repoman.freebsd.org) Received: (from mux@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j2C2hoki067520; Sat, 12 Mar 2005 02:43:50 GMT (envelope-from mux) Message-Id: <200503120243.j2C2hoki067520@repoman.freebsd.org> From: Maxime Henrion Date: Sat, 12 Mar 2005 02:43:50 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/alpha/alpha busdma_machdep.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Mar 2005 02:43:51 -0000 mux 2005-03-12 02:43:50 UTC FreeBSD src repository Modified files: sys/alpha/alpha busdma_machdep.c Log: Fix a long-standing bug in alpha's implementation of busdma. We need to OR the physical address with alpha_XXX_dmamap_or to get the DMA address, like the name of the variable suggests. However, while we were doing this correctly in the alpha_XXX_dmamap() macro, the busdma code added the variable to the physical address instead of or'ing it. Fortunately and if my math is not entirely wrong, you would need more than 128GB of RAM and a device able to do DMA in 64bits to experience the bug. Spotted by: cognet Revision Changes Path 1.50 +4 -4 src/sys/alpha/alpha/busdma_machdep.c