Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 7 Jun 2004 12:49:33 +0200
From:      Anton Berezin <tobez@tobez.org>
To:        David O'Brien <obrien@freebsd.org>
Cc:        perl@freebsd.org
Subject:   Re: [PATCH] p5-Mail-SpamAssassin
Message-ID:  <20040607104933.GC22945@heechee.tobez.org>
In-Reply-To: <20040607102124.GA31190@dragon.nuxi.com>
References:  <20040607102124.GA31190@dragon.nuxi.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 07, 2004 at 03:21:24AM -0700, David O'Brien wrote:
> Does anyone have a problem with the below patch?

> Index: files/patch-CmdLearn.pm
> ===================================================================
> RCS file: files/patch-CmdLearn.pm
> diff -N files/patch-CmdLearn.pm
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ files/patch-CmdLearn.pm	3 Jan 2004 04:19:29 -0000
> @@ -0,0 +1,11 @@
> +--- lib/Mail/SpamAssassin/CmdLearn.pm.orig	Thu Sep 18 21:02:40 2003
> ++++ lib/Mail/SpamAssassin/CmdLearn.pm	Fri Jan  2 20:18:28 2004
> +@@ -43,2 +43,3 @@
> +              'showdots'                         => \$opt{'showdots'},
> ++	     'quiet'				=> \$opt{'quiet'},
> + 	     'no-rebuild|norebuild'		=> \$opt{'norebuild'},
> +@@ -233,3 +234,3 @@
> +     print STDERR "\n" if ($opt{showdots});
> +-    print "Learned from $learnedcount message(s) ($messagecount message(s) examined).\n";
> ++    print "Learned from $learnedcount message(s) ($messagecount message(s) examined).\n" if (!$opt{quiet});
> +   };
> Index: files/patch-sa-learn.raw
> ===================================================================
> RCS file: files/patch-sa-learn.raw
> diff -N files/patch-sa-learn.raw
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ files/patch-sa-learn.raw	3 Jan 2004 02:59:53 -0000
> @@ -0,0 +1,6 @@
> +--- sa-learn.raw.orig	Mon Sep 15 15:59:24 2003
> ++++ sa-learn.raw	Fri Jan  2 18:59:25 2004
> +@@ -75,2 +75,3 @@
> +  --showdots                        Show progress using dots
> ++ --quiet                           Donot output status from command run
> +  --no-rebuild                      Skip building databases after scan

s/donot/do not/

Have you submitted the patch to SA authors, btw?

Otherwise I have no problem with the patch going in.

\Anton.
-- 
Floating point will almost always have enough precision for the task at
hand, and by the time it doesn't, it will. :-)  -- Larry Wall



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040607104933.GC22945>