From owner-freebsd-perl@FreeBSD.ORG  Mon Jun  7 10:49:39 2004
Return-Path: <owner-freebsd-perl@FreeBSD.ORG>
Delivered-To: freebsd-perl@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 09E9B16A4CE; Mon,  7 Jun 2004 10:49:39 +0000 (GMT)
Received: from heechee.tobez.org (heechee.tobez.org [217.157.39.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D5D5143D46; Mon,  7 Jun 2004 10:49:37 +0000 (GMT)
	(envelope-from tobez@tobez.org)
Received: by heechee.tobez.org (Postfix, from userid 1001)
	id BFBCD175A9; Mon,  7 Jun 2004 12:49:33 +0200 (CEST)
Date: Mon, 7 Jun 2004 12:49:33 +0200
From: Anton Berezin <tobez@tobez.org>
To: David O'Brien <obrien@freebsd.org>
Message-ID: <20040607104933.GC22945@heechee.tobez.org>
References: <20040607102124.GA31190@dragon.nuxi.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040607102124.GA31190@dragon.nuxi.com>
User-Agent: Mutt/1.5.6i
cc: perl@freebsd.org
Subject: Re: [PATCH] p5-Mail-SpamAssassin
X-BeenThere: freebsd-perl@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: maintainer of a number of perl-related ports
	<freebsd-perl.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
	<mailto:freebsd-perl-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-perl>
List-Post: <mailto:freebsd-perl@freebsd.org>
List-Help: <mailto:freebsd-perl-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-perl>,
	<mailto:freebsd-perl-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 07 Jun 2004 10:49:39 -0000

On Mon, Jun 07, 2004 at 03:21:24AM -0700, David O'Brien wrote:
> Does anyone have a problem with the below patch?

> Index: files/patch-CmdLearn.pm
> ===================================================================
> RCS file: files/patch-CmdLearn.pm
> diff -N files/patch-CmdLearn.pm
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ files/patch-CmdLearn.pm	3 Jan 2004 04:19:29 -0000
> @@ -0,0 +1,11 @@
> +--- lib/Mail/SpamAssassin/CmdLearn.pm.orig	Thu Sep 18 21:02:40 2003
> ++++ lib/Mail/SpamAssassin/CmdLearn.pm	Fri Jan  2 20:18:28 2004
> +@@ -43,2 +43,3 @@
> +              'showdots'                         => \$opt{'showdots'},
> ++	     'quiet'				=> \$opt{'quiet'},
> + 	     'no-rebuild|norebuild'		=> \$opt{'norebuild'},
> +@@ -233,3 +234,3 @@
> +     print STDERR "\n" if ($opt{showdots});
> +-    print "Learned from $learnedcount message(s) ($messagecount message(s) examined).\n";
> ++    print "Learned from $learnedcount message(s) ($messagecount message(s) examined).\n" if (!$opt{quiet});
> +   };
> Index: files/patch-sa-learn.raw
> ===================================================================
> RCS file: files/patch-sa-learn.raw
> diff -N files/patch-sa-learn.raw
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ files/patch-sa-learn.raw	3 Jan 2004 02:59:53 -0000
> @@ -0,0 +1,6 @@
> +--- sa-learn.raw.orig	Mon Sep 15 15:59:24 2003
> ++++ sa-learn.raw	Fri Jan  2 18:59:25 2004
> +@@ -75,2 +75,3 @@
> +  --showdots                        Show progress using dots
> ++ --quiet                           Donot output status from command run
> +  --no-rebuild                      Skip building databases after scan

s/donot/do not/

Have you submitted the patch to SA authors, btw?

Otherwise I have no problem with the patch going in.

\Anton.
-- 
Floating point will almost always have enough precision for the task at
hand, and by the time it doesn't, it will. :-)  -- Larry Wall